From 13c8591f1c39f9692ecae3ace1e1482c2d61ebc0 Mon Sep 17 00:00:00 2001
From: Baalekshan <69910615+Baalekshan@users.noreply.github.com>
Date: Sat, 20 Apr 2024 21:07:04 +0530
Subject: [PATCH] Require Node version 20+ (#2274)

## Which problem is this PR solving?
#2272

## Description of the changes
-

## How was this change tested?
-

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Baalekshan <baalekshan@gmail.com>
---
 .eslintignore                    | 8 --------
 .eslintrc.js                     | 9 +++++++++
 .github/workflows/lint-build.yml | 2 +-
 .github/workflows/release.yml    | 2 +-
 .github/workflows/unit-tests.yml | 2 +-
 .npmrc                           | 1 +
 .nvmrc                           | 2 +-
 package.json                     | 3 +++
 8 files changed, 17 insertions(+), 12 deletions(-)
 delete mode 100644 .eslintignore
 create mode 100644 .npmrc

diff --git a/.eslintignore b/.eslintignore
deleted file mode 100644
index 5dfa77e5b7..0000000000
--- a/.eslintignore
+++ /dev/null
@@ -1,8 +0,0 @@
-build
-coverage
-packages/plexus/src/LayoutManager/layout.worker*js*
-
-# Ignore generated files
-packages/jaeger-ui/index.d.ts
-packages/plexus/dist
-packages/plexus/lib
diff --git a/.eslintrc.js b/.eslintrc.js
index 13d2700535..e357912ed9 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -19,6 +19,15 @@ module.exports = {
     jest: true,
     jasmine: true,
   },
+  // Add any other files or directories you want to ignore
+  ignorePatterns: [
+    'build/',
+    'coverage/',
+    'packages/plexus/src/LayoutManager/layout.worker*js*',
+    'packages/jaeger-ui/index.d.ts',
+    'packages/plexus/dist/',
+    'packages/plexus/lib/',
+  ],
   settings: {
     'import/resolver': {
       node: {
diff --git a/.github/workflows/lint-build.yml b/.github/workflows/lint-build.yml
index 1a39a8dfe7..a88c27d5f9 100644
--- a/.github/workflows/lint-build.yml
+++ b/.github/workflows/lint-build.yml
@@ -23,7 +23,7 @@ jobs:
       - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
         with:
           cache: yarn
-          node-version: '18'
+          node-version: '20'
       - run: yarn install --frozen-lockfile
       - name: Run depcheck
         run: yarn run depcheck
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 83d25ea621..82877b4db5 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -20,7 +20,7 @@ jobs:
       - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
         with:
           cache: yarn
-          node-version: '18'
+          node-version: '20'
       - run: yarn install --frozen-lockfile
       - run: yarn lint
       - run: yarn build
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
index ec8d7f6b26..0c73fb8ba0 100644
--- a/.github/workflows/unit-tests.yml
+++ b/.github/workflows/unit-tests.yml
@@ -23,7 +23,7 @@ jobs:
       - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
         with:
           cache: yarn
-          node-version: '18'
+          node-version: '20'
       - run: yarn install --frozen-lockfile
       - run: yarn coverage
       - name: Upload coverage to codecov.io
diff --git a/.npmrc b/.npmrc
new file mode 100644
index 0000000000..4fd021952d
--- /dev/null
+++ b/.npmrc
@@ -0,0 +1 @@
+engine-strict=true
\ No newline at end of file
diff --git a/.nvmrc b/.nvmrc
index 3c032078a4..209e3ef4b6 100644
--- a/.nvmrc
+++ b/.nvmrc
@@ -1 +1 @@
-18
+20
diff --git a/package.json b/package.json
index 294d29fde6..5094bb13ee 100644
--- a/package.json
+++ b/package.json
@@ -7,6 +7,9 @@
     "type": "git",
     "url": "https://github.com/jaegertracing/jaeger-ui.git"
   },
+  "engines": {
+    "node": ">=20"
+  },
   "devDependencies": {
     "@babel/eslint-parser": "^7.24.1",
     "@typescript-eslint/eslint-plugin": "7.4.0",