Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jaeger] Jaeger allInOne allow different storage types #603

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rgaduput
Copy link
Contributor

@rgaduput rgaduput commented Sep 19, 2024

What this PR does

Allow different storage backend type for allInOne than just memory/badger.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format,
will close that issue when PR gets merged)

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • [] README.md has been updated to match version/contain new values

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, lgtm

@pavelnikolov
Copy link
Contributor

@rgaduput merging is blocked because the commits are not GPG signed. Could you, please, GPG-sign the commits?

@rgaduput
Copy link
Contributor Author

@rgaduput merging is blocked because the commits are not GPG signed. Could you, please, GPG-sign the commits?

@pavelnikolov fixed it, please check.

@pavelnikolov pavelnikolov merged commit 29a0e21 into jaegertracing:main Sep 20, 2024
2 checks passed
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Oct 20, 2024
Signed-off-by: Reddysekhar Gaduputi <[email protected]>

upgrade jaeger-operator to latest 1.61.0 (jaegertracing#605)

Signed-off-by: Blair Bowden <[email protected]>

added all-in-one deployment and configmap for jaeger-v2

Signed-off-by: Mehul <[email protected]>

lint fix

Signed-off-by: Mehul <[email protected]>

fixed

Signed-off-by: Mehul <[email protected]>

lint fix

Signed-off-by: Mehul <[email protected]>

lint fix

Signed-off-by: Mehul <[email protected]>

fixed using pre-hook

Signed-off-by: Mehul <[email protected]>

fixed --config flag is not been passed

Signed-off-by: mehul <[email protected]>

release ns for config-map.yaml

Signed-off-by: mehul <[email protected]>

testing ci

Signed-off-by: mehul <[email protected]>

testing ci

Signed-off-by: mehul <[email protected]>

fixed ns

Signed-off-by: mehul <[email protected]>

fixed ns

Signed-off-by: mehul <[email protected]>

fixed template

Signed-off-by: mehul <[email protected]>

removed sampling

Signed-off-by: mehul <[email protected]>

removed adaptive sampling from processors

Signed-off-by: mehul <[email protected]>

Revert "Jaeger v2 test2"

Signed-off-by: mehul <[email protected]>

attempt to create v2 chart in v1

Signed-off-by: mehul <[email protected]>

enabled collector query and agent

Signed-off-by: mehul <[email protected]>

version bump

Signed-off-by: mehul <[email protected]>

testing-v2-ci

Signed-off-by: mehul <[email protected]>

testing-v2-ci

Signed-off-by: mehul <[email protected]>

added --helm-extra-set-args flag

Signed-off-by: mehul <[email protected]>

fixed healthcheck port-v2

Signed-off-by: mehul <[email protected]>

Fix health check path

Signed-off-by: Yuri Shkuro <[email protected]>

minor changes

Signed-off-by: mehul <[email protected]>
hellspawn679 pushed a commit to hellspawn679/helm-charts that referenced this pull request Nov 1, 2024
yurishkuro added a commit that referenced this pull request Nov 3, 2024
* Jaeger allInOne allow different storage types (#603)

Signed-off-by: Reddysekhar Gaduputi <[email protected]>

upgrade jaeger-operator to latest 1.61.0 (#605)

Signed-off-by: Blair Bowden <[email protected]>

added all-in-one deployment and configmap for jaeger-v2

Signed-off-by: Mehul <[email protected]>

lint fix

Signed-off-by: Mehul <[email protected]>

fixed

Signed-off-by: Mehul <[email protected]>

lint fix

Signed-off-by: Mehul <[email protected]>

lint fix

Signed-off-by: Mehul <[email protected]>

fixed using pre-hook

Signed-off-by: Mehul <[email protected]>

fixed --config flag is not been passed

Signed-off-by: mehul <[email protected]>

release ns for config-map.yaml

Signed-off-by: mehul <[email protected]>

testing ci

Signed-off-by: mehul <[email protected]>

testing ci

Signed-off-by: mehul <[email protected]>

fixed ns

Signed-off-by: mehul <[email protected]>

fixed ns

Signed-off-by: mehul <[email protected]>

fixed template

Signed-off-by: mehul <[email protected]>

removed sampling

Signed-off-by: mehul <[email protected]>

removed adaptive sampling from processors

Signed-off-by: mehul <[email protected]>

Revert "Jaeger v2 test2"

Signed-off-by: mehul <[email protected]>

attempt to create v2 chart in v1

Signed-off-by: mehul <[email protected]>

enabled collector query and agent

Signed-off-by: mehul <[email protected]>

version bump

Signed-off-by: mehul <[email protected]>

testing-v2-ci

Signed-off-by: mehul <[email protected]>

testing-v2-ci

Signed-off-by: mehul <[email protected]>

added --helm-extra-set-args flag

Signed-off-by: mehul <[email protected]>

fixed healthcheck port-v2

Signed-off-by: mehul <[email protected]>

Fix health check path

Signed-off-by: Yuri Shkuro <[email protected]>

minor changes

Signed-off-by: mehul <[email protected]>

* minor changes

Signed-off-by: mehul <[email protected]>

* added image changes

Signed-off-by: mehul <[email protected]>

* fix lint

Signed-off-by: mehul <[email protected]>

* removed v1 allInOne and added jaeger-v2

Signed-off-by: mehul <[email protected]>

* removed v2 references

Signed-off-by: mehul <[email protected]>

* added allInOne again

Signed-off-by: mehul <[email protected]>

* minor fix

Signed-off-by: mehul <[email protected]>

* fixed how the config is being passed

Signed-off-by: mehul <[email protected]>

* fixed mirror template change

Signed-off-by: mehul <[email protected]>

* use --set-file for user config

Signed-off-by: mehul <[email protected]>

* removed config-test and updated configmap template

Signed-off-by: mehul <[email protected]>

* fixed

Signed-off-by: mehul <[email protected]>

* fixed minor naming

Signed-off-by: mehul <[email protected]>

* indentation

Signed-off-by: Yuri Shkuro <[email protected]>

---------

Signed-off-by: mehul <[email protected]>
Signed-off-by: mehul gautam  <[email protected]>
Signed-off-by: mehul <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Reddysekhar Gaduputi <[email protected]>
Co-authored-by: mehul <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
yurishkuro added a commit that referenced this pull request Nov 19, 2024
* Jaeger allInOne allow different storage types (#603)

Signed-off-by: Reddysekhar Gaduputi <[email protected]>

upgrade jaeger-operator to latest 1.61.0 (#605)

Signed-off-by: Blair Bowden <[email protected]>

added all-in-one deployment and configmap for jaeger-v2

Signed-off-by: Mehul <[email protected]>

lint fix

Signed-off-by: Mehul <[email protected]>

fixed

Signed-off-by: Mehul <[email protected]>

lint fix

Signed-off-by: Mehul <[email protected]>

lint fix

Signed-off-by: Mehul <[email protected]>

fixed using pre-hook

Signed-off-by: Mehul <[email protected]>

fixed --config flag is not been passed

Signed-off-by: mehul <[email protected]>

release ns for config-map.yaml

Signed-off-by: mehul <[email protected]>

testing ci

Signed-off-by: mehul <[email protected]>

testing ci

Signed-off-by: mehul <[email protected]>

fixed ns

Signed-off-by: mehul <[email protected]>

fixed ns

Signed-off-by: mehul <[email protected]>

fixed template

Signed-off-by: mehul <[email protected]>

removed sampling

Signed-off-by: mehul <[email protected]>

removed adaptive sampling from processors

Signed-off-by: mehul <[email protected]>

Revert "Jaeger v2 test2"

Signed-off-by: mehul <[email protected]>

attempt to create v2 chart in v1

Signed-off-by: mehul <[email protected]>

enabled collector query and agent

Signed-off-by: mehul <[email protected]>

version bump

Signed-off-by: mehul <[email protected]>

testing-v2-ci

Signed-off-by: mehul <[email protected]>

testing-v2-ci

Signed-off-by: mehul <[email protected]>

added --helm-extra-set-args flag

Signed-off-by: mehul <[email protected]>

fixed healthcheck port-v2

Signed-off-by: mehul <[email protected]>

Fix health check path

Signed-off-by: Yuri Shkuro <[email protected]>

minor changes

Signed-off-by: mehul <[email protected]>

* minor changes

Signed-off-by: mehul <[email protected]>

* added image changes

Signed-off-by: mehul <[email protected]>

* fix lint

Signed-off-by: mehul <[email protected]>

* removed v1 allInOne and added jaeger-v2

Signed-off-by: mehul <[email protected]>

* removed v2 references

Signed-off-by: mehul <[email protected]>

* added allInOne again

Signed-off-by: mehul <[email protected]>

* minor fix

Signed-off-by: mehul <[email protected]>

* fixed how the config is being passed

Signed-off-by: mehul <[email protected]>

* fixed mirror template change

Signed-off-by: mehul <[email protected]>

* use --set-file for user config

Signed-off-by: mehul <[email protected]>

* removed config-test and updated configmap template

Signed-off-by: mehul <[email protected]>

* fixed

Signed-off-by: mehul <[email protected]>

* fixed minor naming

Signed-off-by: mehul <[email protected]>

* indentation

Signed-off-by: Yuri Shkuro <[email protected]>

* v2-elasticsearch

Signed-off-by: mehul <[email protected]>

* fix ci

Signed-off-by: mehul <[email protected]>

* fix ci

Signed-off-by: mehul <[email protected]>

* fixed

Signed-off-by: mehul <[email protected]>

* fixed and added docs

Signed-off-by: mehul <[email protected]>

* fixed

Signed-off-by: mehul <[email protected]>

* added port

Signed-off-by: mehul <[email protected]>

* fixed

Signed-off-by: mehul <[email protected]>

* fixed

Signed-off-by: mehul <[email protected]>

* fixed typo

Signed-off-by: mehul <[email protected]>

* fixed

Signed-off-by: mehul <[email protected]>

* removed test config

Signed-off-by: mehul <[email protected]>

* updated docs

Signed-off-by: mehul <[email protected]>

---------

Signed-off-by: mehul <[email protected]>
Signed-off-by: mehul gautam  <[email protected]>
Signed-off-by: mehul <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Reddysekhar Gaduputi <[email protected]>
Co-authored-by: mehul <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants