Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A loading state for plugins #77

Open
jadjoubran opened this issue Apr 4, 2018 · 6 comments
Open

A loading state for plugins #77

jadjoubran opened this issue Apr 4, 2018 · 6 comments
Labels
Milestone

Comments

@jadjoubran
Copy link
Owner

jadjoubran commented Apr 4, 2018

using paper-progress

that shows a loader at the top of the plugin
and can be enabled/disabled from the plugins

Feedback? 👍 or 👎

@jadjoubran jadjoubran added this to the 1.5 milestone Apr 5, 2018
@jadjoubran jadjoubran modified the milestones: 1.5, 1.6 Jul 9, 2018
@adithyaChander
Copy link

Hey, Is this issue open? If it is, could I please give it try ? This looks really interesting.

@jadjoubran
Copy link
Owner Author

Hey @adithyaChander
Yes indeed this is still open 😄
Feel free to submit a PR and also feel free to ask me for help throughout if you've got any questions, I'd love to help
Cheers!

@adithyaChander
Copy link

Hey @jadjoubran . Thanks a lot ! :)
I will work on this and submit a PR. This is really exciting. :)

@jadjoubran
Copy link
Owner Author

Thank you! Don't hesitate to ask for help as this one might be a bit tricky
Cheers!

@adithyaChander
Copy link

Yeah, sure. Any input is much appreciated. I am going through the code to understand how the application works. If you think I should start from a specific place, kindly let me know. Thank you once again.

@jadjoubran
Copy link
Owner Author

I did a quick research and we're most likely going to have to do something similar to the below:

<plugin-wrapper> and the plugin that's being loaded in it need to communicate. Either via events or by 1 or 2 way data binding to let the plugin signal that it's in a loading state
And whenever the <plugin-wrapper> is in a loading state, then we show the loader

I'm still not sure exactly how, if you get stuck, I can do further research

plugin-wrapper is in src/plugin-wrapper.html, I think this is where most of the changes will be
and you might need to play with a sample plugin (to trigger the loading state), you can clone any plugin I've used or setup a new plugin from scratch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants