Ability to use ":" instead of "@" in named args

[KoNekoD]

Add ability to use ":" instead of "@" in named args

Sql linter in golang like this

[KoNekoD]

Just add ":" to here https://github.com/jackc/pgx/blob/master/named_args.go#L110

[KoNekoD]

PR #2178

Before(bad)

After (good)

[jackc]

: is tricky because it is also used for type conversion, e.g. select somecol::text. As far as I can tell, #2178 would fail when :: is encountered.

But even if the parser was fixed I'd rather there only be way to denote a named argument.

However, pgx.[Strict]NamedArgs does not require any internal pgx functionality. It simply implements the pgx.QueryRewriter interface. If you really need to use :, you can copy NamedArgs into your project and change it there.

[KoNekoD]

@jackc I see your point, I'll make the edits according to your concerns.

[KoNekoD]

@jackc Done; Commit 2aa476d

This implementation turns out to be independent and takes into account cases of type casts

[jackc]

The code looks more solid now.

But as I said above, I want to keep the simplicity of only having a single delimiter for named arguments.

I think this support for : should be pulled out into your own library or application.

[KoNekoD]

@jackc Are you sure that library users will be comfortable being forced to adjust to your understanding of good? There seem to be some people who don't like it when their IDE frowns on '@' substitutions. Maybe we should pay attention to the convenience for the end user of the library?

[Nerobrain]

@KoNekoD Are you sure that library users will be comfortable being forced to adjust to your understanding of good? There seem to be some people who know the difference between errors and linter faults. Maybe we should pay attention to the workload for the author of the library?

[devsalesexpress]

:é complicado porque também é usado para conversão de tipo, por exemplo select somecol::text. Até onde eu sei, #2178 falharia quando ::fosse encontrado.

Mas mesmo que o analisador fosse corrigido, eu preferiria que houvesse apenas uma maneira de denotar um argumento nomeado.

No entanto, pgx.[Strict]NamedArgsnão requer nenhuma funcionalidade interna do pgx. Ele simplesmente implementa a pgx.QueryRewriterinterface. Se você realmente precisa usar :, você pode copiar NamedArgspara o seu projeto e alterá-lo lá.

Just check if the successor (the next character) is also a colon ':' if it is then it is a parameter so do not replace the value.

Example: select id::integer as id from person where id = :id

In id::integer contains '::' when it finds the first ':' you check if the next character is also a ':' so it will be a cast and not a parameter.