Use pgtype.PreallocBytes in LargeObject's Read.

Fixes #1876.

Author: mitar

large_objects.go

@@ -4,6 +4,8 @@ import (
 	"context"
 	"errors"
 	"io"
+
+	"github.com/jackc/pgx/v5/pgtype"
 )
 
 // The PostgreSQL wire protocol has a limit of 1 GB - 1 per message. See definition of
@@ -115,9 +117,10 @@ func (o *LargeObject) Read(p []byte) (int, error) {
 			expected = maxLargeObjectMessageLength
 		}
 
-		var res []byte
+		res := pgtype.PreallocBytes(p[nTotal:])
 		err := o.tx.QueryRow(o.ctx, "select loread($1, $2)", o.fd, expected).Scan(&res)
-		copy(p[nTotal:], res)
+		// We compute expected so that it always fits into p, so it should never happen
+		// that PreallocBytes's ScanBytes had to allocate a new slice.
 		nTotal += len(res)
 		if err != nil {
 			return nTotal, err