Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event input:start fired twice for single click #209

Open
RickMohr opened this issue Sep 13, 2021 · 3 comments
Open

Event input:start fired twice for single click #209

RickMohr opened this issue Sep 13, 2021 · 3 comments

Comments

@RickMohr
Copy link

If you single click on an iro.ui.Box (not on the handle) the input:start event is fired twice. Please see this pen:

https://codepen.io/RickMohr/pen/ExXXrOB

Open the console, and click on the box -- "input:start" is printed twice.
( It is correctly printed only once if you drag the box's handle or interact with the slider instead of the box.)

@RickMohr
Copy link
Author

Also I believe input:change is sent before input:start, which seems incorrect.

@jaames
Copy link
Owner

jaames commented Sep 14, 2021

Hey, thanks for the report! Unfortunately I don't have the time to look into this at the moment...

My best guess is that this is because I'm adding event listeners for both mouse events and the equivalent touch events, and they're both firing with user input. Might be time to move to pointer events (if browser support is consistent yet?) or perhaps just cancel one event if the other has just been fired. If someone could look into it and confirm this, it would be super appreciated :)

@aditzu09
Copy link

Hi, looks like only input:start is emitted regardless of actual event(start, move, end).
This explains the two input:start; one for click down and one for click up. Would be many more if it is movement in between.

I also didn't have time to go deeper but
if (type === 0 /* Start */) is always true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants