-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GltfLoader issues #2277
Comments
Please provide detailed instructions for reproducing this issue. |
Maybe this: #2103 |
Would reverting 2103 solve this issue? |
Probably yes.
Here is the 3D Model for the test file |
Using a simple test app, I showed that the issue of YBot loading with multiple AnimComposers pre-dates PR 2103. I'll do a bisection search to find where the issue was introduced. Here is the test app: import com.jme3.anim.AnimComposer;
import com.jme3.app.SimpleApplication;
import com.jme3.scene.Node;
import com.jme3.scene.Spatial;
import com.jme3.scene.control.Control;
import com.jme3.scene.plugins.gltf.GltfModelKey;
import java.util.List;
public class TestYBot extends SimpleApplication {
public static void main(String[] args) {
TestYBot app = new TestYBot();
app.start();
}
@Override
public void simpleInitApp() {
GltfModelKey modelKey = new GltfModelKey("YBot.gltf");
Spatial modelRoot = assetManager.loadModel(modelKey);
int numComposers = countControls(modelRoot, AnimComposer.class);
System.out.println("numComposers = " + numComposers);
stop();
}
/**
* Count all controls of the specified type in the specified subtree of a
* scene graph. Note: recursive!
*
* @param <T> subclass of Control
* @param subtree the subtree to analyze (may be null, unaffected)
* @param controlType the subclass of Control to search for
* @return the count (≥0)
*/
private static <T extends Control> int countControls(
Spatial subtree, Class<T> controlType) {
int result = 0;
if (subtree != null) {
int numControls = subtree.getNumControls();
for (int controlI = 0; controlI < numControls; ++controlI) {
Control control = subtree.getControl(controlI);
if (controlType.isAssignableFrom(control.getClass())) {
++result;
}
}
}
if (subtree instanceof Node) {
Node node = (Node) subtree;
List<Spatial> children = node.getChildren();
for (Spatial child : children) {
result += countControls(child, controlType);
}
}
return result;
}
} |
As pointed out in the pr #2103 , this is to solve several issue and inconsistencies with the scenegraph of imported models , it is not backward compatible, but the previous behavior was bugged and source of issues |
The current behavior, with multiple anim composers per model, is clearly bugged. And that change appears to be unrelated to PR 2103. |
The recent changes to the GLTF loader have introduced several problems:
AnimComposer
andSkinningControl
controllers for each geometry in the model. (see here)Other issues reported by adi.barda: (see here)
The text was updated successfully, but these errors were encountered: