Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmsh ext #32

Merged
merged 12 commits into from
Jul 25, 2023
Merged

gmsh ext #32

merged 12 commits into from
Jul 25, 2023

Conversation

jotaraz
Copy link
Collaborator

@jotaraz jotaraz commented Jul 25, 2023

The first version (simplexgrids) of the gmsh-extension now works.
Backwards compatibility with 'Requires' is not given yet

change Project.toml to incorporate the extension
upload the (gmsh-) extension code
include function definitions with implementations in the gmsh extension
added the tests of the gmsh extension
add dependencies for the gmsh extension
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 91.02% and project coverage change: +0.58% 🎉

Comparison is base (596e01f) 69.96% compared to head (6082576) 70.54%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   69.96%   70.54%   +0.58%     
==========================================
  Files          24       25       +1     
  Lines        3602     3758     +156     
==========================================
+ Hits         2520     2651     +131     
- Misses       1082     1107      +25     
Files Changed Coverage Δ
src/simplexgrid.jl 96.91% <0.00%> (-0.16%) ⬇️
ext/ExtendableGridsGmshExt.jl 92.20% <92.20%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-fu j-fu merged commit 664d493 into j-fu:master Jul 25, 2023
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants