Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better fix for negative cell volumes in tensor grid simplexgrid constructor #14

Open
chmerdon opened this issue Mar 22, 2022 · 1 comment
Open

better fix for negative cell volumes in tensor grid simplexgrid constructor #14

chmerdon opened this issue Mar 22, 2022 · 1 comment

Comments

@chmerdon
Copy link
Collaborator

It was observed that the old tensor grid simplexgrid constructor can lead to meshes with negative cell volumes which can confuse solvers and CellFinder. The current quick fix (f9d47ae) corrects this by instantiating CellVolumes and permuting the first two nodes in the those cells that have a negative volume. Can we find a better solution by creating a proper cells3 field in simplexgrid.jl:553 immediately (such that also the bfacenodes are properly set)?
@j-fu
Copy link
Owner

j-fu commented Mar 22, 2022

Ok, I'll register this, but let us keep this open...

@chmerdon chmerdon mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j-fu @chmerdon