fix!: remove lore from being a public module

`lore` was originally intended to serve as a library. However, in kworkflow#128,
it was decided to package it as a separate project instead of
sideloading alongside the `patch-hub` crate.

Additionally, `Patch::new` was detected as unused code and was removed.

Signed-off-by: Ivin Joel Abraham <[email protected]>

Author: ivinjabraham

src/app.rs

@@ -1,4 +1,9 @@
 use crate::infrastructure::logging::Logger;
+use crate::lore::{
+    lore_api_client::BlockingLoreAPIClient,
+    lore_session,
+    patch::{Author, Patch},
+};
 use crate::{
     infrastructure::logging,
     log_on_error,
@@ -8,11 +13,6 @@ use ansi_to_tui::IntoText;
 use color_eyre::eyre::bail;
 use config::Config;
 use cover_renderer::render_cover;
-use patch_hub::lore::{
-    lore_api_client::BlockingLoreAPIClient,
-    lore_session,
-    patch::{Author, Patch},
-};
 use patch_renderer::{render_patch_preview, PatchRenderer};
 use ratatui::text::Text;
 use screens::{

src/app/screens/bookmarked.rs

@@ -1,4 +1,4 @@
-use patch_hub::lore::patch::Patch;
+use crate::lore::patch::Patch;
 
 pub struct BookmarkedPatchsets {
     pub bookmarked_patchsets: Vec<Patch>,

src/app/screens/details_actions.rs

@@ -1,16 +1,23 @@
-use crate::app::config::{Config, KernelTree};
-
-use super::CurrentScreen;
-use ::patch_hub::lore::{lore_api_client::BlockingLoreAPIClient, lore_session, patch::Patch};
 use color_eyre::eyre::{bail, eyre};
-use patch_hub::lore::patch::Author;
 use ratatui::text::Text;
+
 use std::{
     collections::{HashMap, HashSet},
     path::Path,
     process::Command,
 };
 
+use crate::{
+    app::config::{Config, KernelTree},
+    lore::{
+        lore_api_client::BlockingLoreAPIClient,
+        lore_session,
+        patch::{Author, Patch},
+    },
+};
+
+use super::CurrentScreen;
+
 pub struct DetailsActions {
     pub representative_patch: Patch,
     /// Raw patches as plain text files

src/app/screens/latest.rs

@@ -1,6 +1,7 @@
 use color_eyre::eyre::bail;
 use derive_getters::Getters;
-use patch_hub::lore::{
+
+use crate::lore::{
     lore_api_client::{BlockingLoreAPIClient, ClientError},
     lore_session::{LoreSession, LoreSessionError},
     patch::Patch,

src/app/screens/mail_list.rs

@@ -1,5 +1,6 @@
 use color_eyre::eyre::bail;
-use patch_hub::lore::{
+
+use crate::lore::{
     lore_api_client::BlockingLoreAPIClient, lore_session, mailing_list::MailingList,
 };
 

src/lib.rs

@@ -1,22 +1,23 @@
-use crate::lore::lore_api_client::{
-    AvailableListsRequest, ClientError, PatchFeedRequest, PatchHTMLRequest,
-};
-use crate::lore::mailing_list::MailingList;
-use crate::lore::patch::{Patch, PatchFeed, PatchRegex};
 use derive_getters::Getters;
 use regex::Regex;
 use serde_xml_rs::from_str;
-use std::collections::{HashMap, HashSet};
-use std::io::{BufRead, BufReader};
-use std::mem::swap;
-use std::path::Path;
-use std::process::{Command, Stdio};
-use std::sync::LazyLock;
+use thiserror::Error;
+
 use std::{
+    collections::{HashMap, HashSet},
     fs::{self, File},
-    io,
+    io::{self, BufRead, BufReader},
+    mem::swap,
+    path::Path,
+    process::{Command, Stdio},
+    sync::LazyLock,
+};
+
+use crate::lore::{
+    lore_api_client::{AvailableListsRequest, ClientError, PatchFeedRequest, PatchHTMLRequest},
+    mailing_list::MailingList,
+    patch::{Patch, PatchFeed, PatchRegex},
 };
-use thiserror::Error;
 
 #[cfg(test)]
 mod tests;

src/lore/lore_session.rs

@@ -62,25 +62,6 @@ fn default_total_in_series() -> usize {
 }
 
 impl Patch {
-    pub fn new(
-        title: String,
-        author: Author,
-        message_id: MessageID,
-        in_reply_to: Option<MessageID>,
-        updated: String,
-    ) -> Patch {
-        Patch {
-            title,
-            author,
-            version: 1,
-            number_in_series: 1,
-            total_in_series: 1,
-            message_id,
-            in_reply_to,
-            updated,
-        }
-    }
-
     pub fn version(&self) -> usize {
         self.version
     }

src/lore.rs renamed to src/lore/mod.rs

@@ -3,18 +3,27 @@ use serde_xml_rs::from_str;
 
 #[test]
 fn can_deserialize_patch_without_in_reply_to() {
-    let expected_patch: Patch = Patch::new(
-        "[PATCH 0/42] hitchhiker/guide: Complete Collection".to_string(),
-        Author {
+    let expected_patch: Patch = {
+        let title = "[PATCH 0/42] hitchhiker/guide: Complete Collection".to_string();
+        let author = Author {
             name: "Foo Bar".to_string(),
             email: "[email protected]".to_string(),
-        },
-        MessageID {
+        };
+        let message_id = MessageID {
             href: "http://lore.kernel.org/some-list/[email protected]".to_string(),
-        },
-        None,
-        "2024-07-06T19:15:48Z".to_string(),
-    );
+        };
+        let updated = "2024-07-06T19:15:48Z".to_string();
+        Patch {
+            title,
+            author,
+            version: 1,
+            number_in_series: 1,
+            total_in_series: 1,
+            message_id,
+            in_reply_to: None,
+            updated,
+        }
+    };
     let serialized_patch: &str = r#"
         <entry xmlns:thr="http://purl.org/syndication/thread/1.0">
             <author>
@@ -40,20 +49,30 @@ fn can_deserialize_patch_without_in_reply_to() {
 
 #[test]
 fn can_deserialize_patch_with_in_reply_to() {
-    let expected_patch: Patch = Patch::new(
-        "[PATCH 3/42] hitchhiker/guide: Life, the Universe and Everything".to_string(),
-        Author {
+    let expected_patch: Patch = {
+        let title = "[PATCH 3/42] hitchhiker/guide: Life, the Universe and Everything".to_string();
+        let author = Author {
             name: "Foo Bar".to_string(),
             email: "[email protected]".to_string(),
-        },
-        MessageID {
+        };
+        let message_id = MessageID {
             href: "http://lore.kernel.org/some-list/[email protected]".to_string(),
-        },
-        Some(MessageID {
+        };
+        let in_reply_to = Some(MessageID {
             href: "http://lore.kernel.org/some-list/[email protected]".to_string(),
-        }),
-        "2024-07-06T19:16:53Z".to_string(),
-    );
+        });
+        let updated = "2024-07-06T19:16:53Z".to_string();
+        Patch {
+            title,
+            author,
+            version: 1,
+            number_in_series: 1,
+            total_in_series: 1,
+            message_id,
+            in_reply_to,
+            updated,
+        }
+    };
     let serialized_patch: &str = r#"
         <entry xmlns:thr="http://purl.org/syndication/thread/1.0">
             <author>
@@ -83,20 +102,31 @@ fn can_deserialize_patch_with_in_reply_to() {
 #[test]
 fn test_update_patch_metadata() {
     let patch_regex: PatchRegex = PatchRegex::new();
-    let mut patch: Patch = Patch::new(
-        "[RESEND][v7 PATCH 3/42] hitchhiker/guide: Life, the Universe and Everything".to_string(),
-        Author {
+    let mut patch: Patch = {
+        let title = "[RESEND][v7 PATCH 3/42] hitchhiker/guide: Life, the Universe and Everything"
+            .to_string();
+        let author = Author {
             name: "Foo Bar".to_string(),
             email: "[email protected]".to_string(),
-        },
-        MessageID {
+        };
+        let message_id = MessageID {
             href: "http://lore.kernel.org/some-list/[email protected]".to_string(),
-        },
-        Some(MessageID {
+        };
+        let in_reply_to = Some(MessageID {
             href: "http://lore.kernel.org/some-list/[email protected]".to_string(),
-        }),
-        "2024-07-06T19:16:53Z".to_string(),
-    );
+        });
+        let updated = "2024-07-06T19:16:53Z".to_string();
+        Patch {
+            title,
+            author,
+            version: 1,
+            number_in_series: 1,
+            total_in_series: 1,
+            message_id,
+            in_reply_to,
+            updated,
+        }
+    };
 
     patch.update_patch_metadata(&patch_regex);