Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating several frames at one decoder step #2

Open
xcmyz opened this issue Jun 13, 2020 · 1 comment
Open

Generating several frames at one decoder step #2

xcmyz opened this issue Jun 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@xcmyz
Copy link

xcmyz commented Jun 13, 2020

Wonderful work!
I have one question when I look into your readme.
The difference of durian between fastspeech is its autoregressive structure, which lets durian can generate better wav. It use previous output as input of current step. However, in the picture of baseline model, it is different from description of paper.
image
Besides, I think it is important to generate r steps of mel spectrogram at once (refer paper of tacotron), which is also difficulty when implementing durian. I hope you can implement this part.

Thank you!

@ivanvovk
Copy link
Owner

ivanvovk commented Jun 13, 2020

Yeah, you're right. My baseline model doesn't take into account any info about previous steps. So, that's why it is baseline :) However, for paper-based version, which is also implemented here and also reported in README, self-conditioning decoder is provided - I wrote it in key differences for "vanilla version". I've done baseline just for testing. I guess I just need to remove it to not make others got confused. What about several steps generation at one time - yes, it is a good idea and I think it can be easily added to current implementation in the near future, I will mark it, thank you.

@ivanvovk ivanvovk added the enhancement New feature or request label Jun 13, 2020
@ivanvovk ivanvovk changed the title Description of Model Generating several frames at one decoder step Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants