Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in model name & system messages #7

Open
skyne98 opened this issue Apr 8, 2024 · 2 comments
Open

Typo in model name & system messages #7

skyne98 opened this issue Apr 8, 2024 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@skyne98
Copy link

skyne98 commented Apr 8, 2024

Hi! Thanks for the wonderful crate :)

A couple of things which I have encountered during my testing (and why I had to have a local copy of the crate):

  1. open-mixtral-8x7b is spelled like open-mistral-8x7b and doesn't work
  2. There is no support for system messages out of the box (it seems?) so I had to add one!
  3. Finish reason "length" is not supported

Otherwise, amazing work!

@skyne98 skyne98 added the bug Something isn't working label Apr 8, 2024
@ivangabriele ivangabriele added the enhancement New feature or request label Apr 12, 2024
@ivangabriele ivangabriele self-assigned this Apr 12, 2024
@ivangabriele
Copy link
Owner

ivangabriele commented Apr 12, 2024

@skyne98 Thanks for the feedback! The open-mixtral-8x7b is an easy fix I'll add today. And I'll implement the system message which seems like a must-have indeed.

As for the finish reason length I'm not sure I understand what it represents. I know the finish reason prop and what't its purpose, it's just the "length" part that confuses me.

@skyne98
Copy link
Author

skyne98 commented Apr 12, 2024

That finish reason is provided when your request ends due to the "max tokens" limitation (prop) 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants