-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port CLI interface to github.com/urfave/cli/v2 #46
Comments
It seems like a good idea now, because smug has grown and probably will continue. I want to refactor tests a little bit, and then I'll try to start moving to |
I will find time to to some initial setup. |
@mipmip @ivaaaan I see that you were working on the It wasn't merged either? Was it deleted by mistake? I have some time on my hands and would love to work on smug in my free time. I have used |
I don't know exactly what the current status is. It seems to be merged but the code seems to be missing |
Yeah, perhaps the branch was deleted from GitHub by mistake. |
I have been working on it for some time, but then abandoned it due to a lack of free time. If you want to add something new to smug, the best way is to create a new branch from the |
I'm closing this for now, because I don't think the big refactoring is coming soon. Thanks for the work you did @mipmip, but unfortunately I don't have the resources to finish it. |
I did spent a lot off time in the PR with the port. I would appreciate a another review. You already merged it once :). I know for sure I have the Diffs somewhere. |
Maybe @dufferzafar is interested in doing a review and a new PR? |
Yes. I would love to help with the review, adding any new tests etc. |
Feel free to take the branch and proceed then. You can email me if you have any questions, I'll be happy to help you :) |
That's the open source spirit. @dufferzafar I found the feature branch here: https://github.com/mipmip/smug/tree/clilib. Feel free to ask me support on anything. |
If you implement this CLI library you loose a lot of overhead code for your commands and options. Beside this you get usage documentation and autocomplete without extra coding. If you like I can help.
The text was updated successfully, but these errors were encountered: