Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port CLI interface to github.com/urfave/cli/v2 #46

Open
mipmip opened this issue Mar 16, 2021 · 12 comments
Open

Port CLI interface to github.com/urfave/cli/v2 #46

mipmip opened this issue Mar 16, 2021 · 12 comments

Comments

@mipmip
Copy link
Contributor

mipmip commented Mar 16, 2021

If you implement this CLI library you loose a lot of overhead code for your commands and options. Beside this you get usage documentation and autocomplete without extra coding. If you like I can help.

@ivaaaan
Copy link
Owner

ivaaaan commented Apr 27, 2021

It seems like a good idea now, because smug has grown and probably will continue. I want to refactor tests a little bit, and then I'll try to start moving to urfave/cli/v2. I would appreciate any help. Perhaps move command by command

@mipmip
Copy link
Contributor Author

mipmip commented May 4, 2021

I will find time to to some initial setup.

@dufferzafar
Copy link

@mipmip @ivaaaan I see that you were working on the clilib branch of this repository, but I don't see that branch anywhere now.

It wasn't merged either? Was it deleted by mistake?

I have some time on my hands and would love to work on smug in my free time. I have used tmuxp - https://github.com/tmux-python/tmuxp before which has a few features that smug doesn't. Like detecting currently running commands so they can be dumped with smug print.

@mipmip
Copy link
Contributor Author

mipmip commented May 30, 2022

I don't know exactly what the current status is. It seems to be merged but the code seems to be missing

@dufferzafar
Copy link

Yeah, perhaps the branch was deleted from GitHub by mistake.

@ivaaaan
Copy link
Owner

ivaaaan commented May 30, 2022

I have been working on it for some time, but then abandoned it due to a lack of free time. If you want to add something new to smug, the best way is to create a new branch from the master.

@ivaaaan
Copy link
Owner

ivaaaan commented May 31, 2022

I'm closing this for now, because I don't think the big refactoring is coming soon. Thanks for the work you did @mipmip, but unfortunately I don't have the resources to finish it.

@ivaaaan ivaaaan closed this as completed May 31, 2022
@mipmip
Copy link
Contributor Author

mipmip commented May 31, 2022

I did spent a lot off time in the PR with the port. I would appreciate a another review. You already merged it once :). I know for sure I have the Diffs somewhere.

@mipmip
Copy link
Contributor Author

mipmip commented May 31, 2022

Maybe @dufferzafar is interested in doing a review and a new PR?

@dufferzafar
Copy link

Yes. I would love to help with the review, adding any new tests etc.

@ivaaaan
Copy link
Owner

ivaaaan commented May 31, 2022

Feel free to take the branch and proceed then. You can email me if you have any questions, I'll be happy to help you :)
I'll reopen the issue in this case.

@ivaaaan ivaaaan reopened this May 31, 2022
@mipmip
Copy link
Contributor Author

mipmip commented May 31, 2022

That's the open source spirit. @dufferzafar I found the feature branch here: https://github.com/mipmip/smug/tree/clilib. Feel free to ask me support on anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants