-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detach
mode seems not working with 0.3.5 release
#129
Comments
Hey. I think the problem is that the path is not correct. This patch should fix it test do
(testpath/".config/smug/test.yml").write <<~EOF
session: homebrew-test-session
root: .
windows:
- name: test
EOF
assert_equal(version, shell_output(bin/"smug").lines.first.split("Version").last.chomp)
with_env(TERM: "screen-256color") do
- system bin/"smug", "start", "--file", testpath/"test.yml", "--detach"
+ system bin/"smug", "start", "--file", testpath/".config/smug/test.yml", "--detach"
end
assert_empty shell_output("tmux has-session -t homebrew-test-session")
system "tmux", "kill-session", "-t", "homebrew-test-session"
end |
@ivaaaan sorry about the delay, and thanks for the pointer, I am gonna retry the PR now. 🙏 |
still the same error
|
cc @ivaaaan |
The error is different now that. I couldn't reproduce this with the test config on my machine. Help would be appreciated, I don't know much details on how homebrew runs its tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
👋 while bumping smug to 0.3.5 release, seeing some regression test issue with the detached mode
full build log, https://github.com/Homebrew/homebrew-core/actions/runs/11295405800/job/31418666575?pr=193749
relates to Homebrew/homebrew-core#193749
The text was updated successfully, but these errors were encountered: