-
Notifications
You must be signed in to change notification settings - Fork 70
Open
Labels
BREAKING CHANGEIndicates a breaking changeIndicates a breaking changetype: featureIndicates a feature or enhancementIndicates a feature or enhancement
Description
The current type of the type argument is string, which may cause errors if we typed a wrong value.
But if we specify the type to 'default' | 'info' | 'success' | 'warning' | 'error', we can have not only stricter type checks but also auto-completion support from the editor.
type NotificationType = 'default' | 'info' | 'success' | 'warning' | 'error';
class NotifierService {
...
notify(type: NotificationType, ...) {
...
}
...
}Metadata
Metadata
Assignees
Labels
BREAKING CHANGEIndicates a breaking changeIndicates a breaking changetype: featureIndicates a feature or enhancementIndicates a feature or enhancement