diff --git a/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap b/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap index 642fd629ad..aa94ad761a 100644 --- a/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap +++ b/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap @@ -89,9 +89,7 @@ exports[` render renders detailLink 1`] = ` className="Ddg--DetailsPanel--LoadingWrapper" > render renders while loading 1`] = ` className="Ddg--DetailsPanel--LoadingWrapper" > Loading indicator is displayed 1`] = ` > @@ -735,7 +734,6 @@ exports[` Loading indicator is displayed when xDomain is empty 1`] > diff --git a/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap b/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap index ea5255080a..fc43653e88 100644 --- a/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap +++ b/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap @@ -11,7 +11,6 @@ exports[` "Couldn’t fetch data" displayed 1`] = ` exports[` Loading indicator is displayed 1`] = ` `; diff --git a/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap b/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap index 54a3975b79..fbc8341847 100644 --- a/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap +++ b/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap @@ -44,7 +44,6 @@ exports[`QualityMetrics UnconnectedQualityMetrics render renders when loading 1` /> `; diff --git a/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx b/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx index 282e1188e3..614892e3ef 100644 --- a/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx +++ b/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx @@ -25,20 +25,19 @@ type LoadingIndicatorProps = { style?: React.CSSProperties; }; -export default function LoadingIndicator(props: LoadingIndicatorProps) { - const { centered, vcentered, className, small, ...rest } = props; +export default function LoadingIndicator({ + centered = false, + vcentered, + className, + small = false, + ...rest +}: LoadingIndicatorProps) { const cls = ` LoadingIndicator ${centered ? 'is-centered' : ''} ${vcentered ? 'is-vcentered' : ''} ${small ? 'is-small' : ''} - ${className || ''} + ${className} `; return ; } - -LoadingIndicator.defaultProps = { - centered: false, - className: undefined, - small: false, -};