From 578e70b09fcd6cd31a5d0ed434f6d03beae297d6 Mon Sep 17 00:00:00 2001
From: Abhishek <bumblebee31304@gmail.com>
Date: Mon, 20 Jan 2025 13:53:43 +0530
Subject: [PATCH] Remove defaultProps from LoadingIndicator

Partially Resolves #2596
- Updated the LoadingIndicator component to remove defaultProps so as to avoid the deprecation warnings.
- Updated the snapshots so as to match the new LoadingIndicator.

Signed-off-by: Abhishek <bumblebee31304@gmail.com>
---
 .../__snapshots__/DetailsPanel.test.js.snap       |  4 ----
 .../__snapshots__/serviceGraph.test.js.snap       |  2 --
 .../__snapshots__/index.test.js.snap              |  1 -
 .../__snapshots__/index.test.js.snap              |  1 -
 .../src/components/common/LoadingIndicator.tsx    | 15 +++++++--------
 5 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap b/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap
index 642fd629ad..aa94ad761a 100644
--- a/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap
+++ b/packages/jaeger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap
@@ -89,9 +89,7 @@ exports[`<SidePanel> render renders detailLink 1`] = `
     className="Ddg--DetailsPanel--LoadingWrapper"
   >
     <LoadingIndicator
-      centered={false}
       className="Ddg--DetailsPanel--LoadingIndicator"
-      small={false}
     />
   </div>
   <VerticalResizer
@@ -268,9 +266,7 @@ exports[`<SidePanel> render renders while loading 1`] = `
     className="Ddg--DetailsPanel--LoadingWrapper"
   >
     <LoadingIndicator
-      centered={false}
       className="Ddg--DetailsPanel--LoadingIndicator"
-      small={false}
     />
   </div>
   <VerticalResizer
diff --git a/packages/jaeger-ui/src/components/Monitor/ServicesView/__snapshots__/serviceGraph.test.js.snap b/packages/jaeger-ui/src/components/Monitor/ServicesView/__snapshots__/serviceGraph.test.js.snap
index def2f5df7f..d460ba0e65 100644
--- a/packages/jaeger-ui/src/components/Monitor/ServicesView/__snapshots__/serviceGraph.test.js.snap
+++ b/packages/jaeger-ui/src/components/Monitor/ServicesView/__snapshots__/serviceGraph.test.js.snap
@@ -704,7 +704,6 @@ exports[`<ServiceGraph> Loading indicator is displayed 1`] = `
   >
     <LoadingIndicator
       centered={true}
-      small={false}
     />
   </div>
 </div>
@@ -735,7 +734,6 @@ exports[`<ServiceGraph> Loading indicator is displayed when xDomain is empty 1`]
   >
     <LoadingIndicator
       centered={true}
-      small={false}
     />
   </div>
 </div>
diff --git a/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap b/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap
index ea5255080a..fc43653e88 100644
--- a/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap
+++ b/packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap
@@ -11,7 +11,6 @@ exports[`<OperationTableDetails> "Couldn’t fetch data" displayed 1`] = `
 exports[`<OperationTableDetails> Loading indicator is displayed 1`] = `
 <LoadingIndicator
   centered={true}
-  small={false}
 />
 `;
 
diff --git a/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap b/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap
index 54a3975b79..fbc8341847 100644
--- a/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap
+++ b/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap
@@ -44,7 +44,6 @@ exports[`QualityMetrics UnconnectedQualityMetrics render renders when loading 1`
   />
   <LoadingIndicator
     centered={true}
-    small={false}
   />
 </div>
 `;
diff --git a/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx b/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx
index 282e1188e3..17ceac7178 100644
--- a/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx
+++ b/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx
@@ -25,8 +25,13 @@ type LoadingIndicatorProps = {
   style?: React.CSSProperties;
 };
 
-export default function LoadingIndicator(props: LoadingIndicatorProps) {
-  const { centered, vcentered, className, small, ...rest } = props;
+export default function LoadingIndicator({
+  centered = false,
+  vcentered,
+  className = undefined,
+  small = false,
+  ...rest
+}: LoadingIndicatorProps) {
   const cls = `
     LoadingIndicator
     ${centered ? 'is-centered' : ''}
@@ -36,9 +41,3 @@ export default function LoadingIndicator(props: LoadingIndicatorProps) {
   `;
   return <LuLoader2 className={cls} {...rest} />;
 }
-
-LoadingIndicator.defaultProps = {
-  centered: false,
-  className: undefined,
-  small: false,
-};