Skip to content

Files saved with capitalized extensions #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
diced opened this issue May 25, 2025 · 0 comments · Fixed by #128
Closed

Files saved with capitalized extensions #127

diced opened this issue May 25, 2025 · 0 comments · Fixed by #128

Comments

@diced
Copy link
Contributor

diced commented May 25, 2025

Describe the bug
Files are saved with capitalized filenames: screenshot-1748124585-main-1512x982.PNG, instead of something like screenshot-1748124585-main-1512x982.png. pretty small issue but it annoyed me 😂

To Reproduce
Steps to reproduce the behavior:

  1. Post Media Tasks: Save to disk + Clipboard
  2. Take any screenshot, region, entire screen, or window produce the same filename
  3. Open a terminal or finder and head over to where the screenshot is stored
  4. The screenshot that is saved will have an extension like PNG

Expected behavior
File should have a lowercase extension, png, jpg, etc.

Desktop (please complete the following information):

  • OS: MacOS 15.5 (24F74)
  • Version 4.2.3 from Homebrew

Additional context
I would've tried to make a pull request to fix this since it seemed like a simple fix but I was unable to build the project using Xcode and a personal account due to something requiring iCloud (?), anyway I think it's a simple fix:

In: https://github.com/itoolio/ishare/blob/dev/ishare/Capture/ImageCapture.swift#L44

    let uniqueFilename = "\(fileName)-\(timestamp)\(suffix).\(fileType)"

I believe should actually be:

    let uniqueFilename = "\(fileName)-\(timestamp)\(suffix).\(fileType.rawValue)"

I have no experience with swift but I assume that it's not reading the string value of the enum but rather using the name associated with it, PNG, JPG, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant