Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVC SSH REMOTE: for ssh connections that use passwords instead of private keys dvc still tries to read key first #17

Open
mrkuchkov opened this issue Nov 24, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@mrkuchkov
Copy link

Bug Report

DVC PULL: for ssh connections that use passwords instead of private keys dvc pull still tries to read key first

Description

For ssh connections that use passwords instead of private keys dvc still tries to read the key file first.
In cases when there's no id_rsa file on the host system, the command fails.
If for some reason dvc cannot read the key file command it fails as well.

Reproduce

  1. Add ssh remote with password authorization only.
  2. Delete ~/.ssh/id_rsa private key on the host system
  3. Add user and password to remote
  4. Do dvc pull
  5. Get there is no ~/.ssh/id_rsa private key error message

Expected

Ideally, dvc should check if the password is provided in the config file and try it first, and if the password does not work fail with the Error Message.

Environment information

MacOS

Output of dvc doctor:

$ dvc doctor

DVC version: 2.8.1 (pip)

Platform: Python 3.6.5 on Darwin-20.6.0-x86_64-i386-64bit
Supports:
azure (adlfs = 2021.9.1, knack = 0.8.2, azure-identity = 1.7.0),
gdrive (pydrive2 = 1.10.0),
gs (gcsfs = 2021.10.0),
hdfs (fsspec = 2021.10.0, pyarrow = 6.0.0),
webhdfs (fsspec = 2021.10.0),
http (aiohttp = 3.6.2, aiohttp-retry = 2.4.6),
https (aiohttp = 3.6.2, aiohttp-retry = 2.4.6),
s3 (s3fs = 2021.10.0, boto3 = 1.17.106),
ssh (sshfs = 2021.9.0),
oss (ossfs = 2021.8.0),
webdav (webdav4 = 0.9.3),
webdavs (webdav4 = 0.9.3)

Additional Information (if any):

@efiop efiop transferred this issue from iterative/dvc Jan 1, 2023
@omesser omesser added the bug Something isn't working label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants