Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html: Improve aesthetics #21

Open
5 tasks
daavoo opened this issue Mar 31, 2022 · 2 comments
Open
5 tasks

html: Improve aesthetics #21

daavoo opened this issue Mar 31, 2022 · 2 comments
Labels
A: html Area: HTML report enhancement New feature or request

Comments

@daavoo
Copy link
Contributor

daavoo commented Mar 31, 2022 •
edited
Loading

Current look:

Screenshot 2022-03-31 at 17-03-41 DVC Plot

Here are some ideas:
@daavoo daavoo added the enhancement New feature or request label Mar 31, 2022
@daavoo
Copy link
Contributor Author

daavoo commented Mar 31, 2022

HTML definition:

dvc-render/src/dvc_render/html.py

Lines 12 to 22 in 3196929

PAGE_HTML = """<!DOCTYPE html>
<html>
<head>
{refresh_tag}
<title>DVC Plot</title>
{scripts}
</head>
<body>
{plot_divs}
</body>
</html>"""

Plot div:

dvc-render/src/dvc_render/vega.py

Lines 16 to 23 in 3196929

DIV = """
<div id = "{id}">
<script type = "text/javascript">
var spec = {partial};
vegaEmbed('#{id}', spec);
</script>
</div>
"""

Image div:

dvc-render/src/dvc_render/image.py

Lines 6 to 12 in 3196929

DIV = """
<div
id="{id}"
style="border:1px solid black;text-align:center;
white-space: nowrap;overflow-y:hidden;">
{partial}
</div>"""

@daavoo
Copy link
Contributor Author

daavoo commented Apr 7, 2022

Related discussion: iterative/dvc#7380

@daavoo daavoo added the A: html Area: HTML report label Nov 18, 2022
@daavoo daavoo mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: html Area: HTML report enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daavoo