Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared OAuth refresh token not accepted #15284

Closed
dkocher opened this issue Oct 27, 2023 · 2 comments · Fixed by #15393 · May be fixed by #15114
Closed

Shared OAuth refresh token not accepted #15284

dkocher opened this issue Oct 27, 2023 · 2 comments · Fixed by #15393 · May be fixed by #15114
Assignees
@dkocher
Labels
bug googledrive Google Drive Protocol Implementation googlestorage Google Cloud Storage Protocol Implementation onedrive OneDrive Protocol Implementation
Milestone
8.7.2

Comments

@dkocher
Copy link
Contributor

dkocher commented Oct 27, 2023

From #15230. OAuth tokens saved in the credentials manager shared between Cyberduck and Mountain Duck seem to cause issues for OneDrive although using the same registered OAuth Client ID for Cyberduck and Mountain Duck.

AADSTS70000: The provided value for the input parameter 'refresh_token' or 'assertion' is not valid. The token was issued for a different client id
@dkocher dkocher added the onedrive OneDrive Protocol Implementation label Oct 27, 2023
@dkocher dkocher added this to the 8.7.1 milestone Oct 27, 2023
@dkocher dkocher self-assigned this Oct 27, 2023
@AliveDevil
Copy link
Contributor

AliveDevil commented Oct 30, 2023 •
edited by dkocher
Loading

using the same registered OAuth Client ID for Cyberduck and Mountain Duck

This is false. OAuth Client Ids differ for

  • OneDrive
  • Google Drive
  • Google Cloud Storage
  • Dropbox

@AliveDevil AliveDevil added googledrive Google Drive Protocol Implementation googlestorage Google Cloud Storage Protocol Implementation dropbox Dropbox Protocol Implementation labels Oct 30, 2023
@dkocher dkocher added bug and removed dropbox Dropbox Protocol Implementation labels Oct 30, 2023
@dkocher
Copy link
Contributor Author

dkocher commented Nov 1, 2023

Related issue in #15309.

@dkocher dkocher linked a pull request Nov 1, 2023 that will close this issue
Make OAuth prefix used for storing credentials configurable; use port… #15114
Draft
@dkocher dkocher modified the milestones: 8.7.1, 8.7.2 Nov 3, 2023
dkocher added a commit that referenced this issue Nov 22, 2023
@dkocher
Save OAuth tokens with client id. Fix #15284.
78ac9b4
@dkocher dkocher linked a pull request Nov 22, 2023 that will close this issue
Save OAuth tokens with port number, scheme and hostname from token URL. #15393
Merged
dkocher added a commit that referenced this issue Nov 23, 2023
@dkocher
Save new tokens using OAuth Client ID as prefix. Fix #15284.
8ef758d
dkocher added a commit that referenced this issue Nov 23, 2023
@dkocher
Save new tokens using OAuth Client ID as prefix. Fix #15284.
1f257ff
@chenkins chenkins mentioned this issue Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkocher dkocher

Labels
bug googledrive Google Drive Protocol Implementation googlestorage Google Cloud Storage Protocol Implementation onedrive OneDrive Protocol Implementation
Projects
None yet
Milestone
8.7.2
2 participants
@dkocher @AliveDevil