Skip to content

Commit 1307910

Browse files
committed
Fix test.
1 parent 2e99e6f commit 1307910

File tree

3 files changed

+22
-12
lines changed

3 files changed

+22
-12
lines changed

openstack/src/main/java/ch/cyberduck/core/openstack/SwiftFindFeature.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,15 @@
2727
public class SwiftFindFeature implements Find {
2828

2929
private final SwiftSession session;
30+
private final SwiftRegionService regionService;
3031

3132
public SwiftFindFeature(final SwiftSession session) {
33+
this(session, new SwiftRegionService(session));
34+
}
35+
36+
public SwiftFindFeature(final SwiftSession session, final SwiftRegionService regionService) {
3237
this.session = session;
38+
this.regionService = regionService;
3339
}
3440

3541
@Override
@@ -38,7 +44,7 @@ public boolean find(final Path file, final ListProgressListener listener) throws
3844
return true;
3945
}
4046
try {
41-
new SwiftAttributesFinderFeature(session).find(file, listener);
47+
new SwiftAttributesFinderFeature(session, regionService).find(file, listener);
4248
return true;
4349
}
4450
catch(NotfoundException e) {

openstack/src/main/java/ch/cyberduck/core/openstack/SwiftLocationFeature.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ public Name getLocation(final Path file) throws BackgroundException {
110110
for(Region r : client.getRegions()) {
111111
try {
112112
cache.put(container, new SwiftRegion(client.getContainerInfo(r, container.getName()).getRegion().getRegionId()));
113+
// Found region for container
114+
break;
113115
}
114116
catch(ContainerNotFoundException | AuthorizationException e) {
115117
log.warn("Failure finding container {} in region {}", container, r.getRegionId());

openstack/src/test/java/ch/cyberduck/core/openstack/SwiftDirectoryFeatureTest.java

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,15 @@ public class SwiftDirectoryFeatureTest extends AbstractSwiftTest {
4242

4343
@Test
4444
public void testCreateContainer() throws Exception {
45-
final SwiftDirectoryFeature feature = new SwiftDirectoryFeature(session, new SwiftRegionService(session), new SwiftWriteFeature(session, new SwiftRegionService(session)));
45+
final SwiftRegionService region = new SwiftRegionService(session);
46+
final SwiftDirectoryFeature feature = new SwiftDirectoryFeature(session, region, new SwiftWriteFeature(session, region));
4647
final Path test = new Path(new AlphanumericRandomStringService().random(), EnumSet.of(Path.Type.directory));
4748
final Path container = feature.mkdir(test, new TransferStatus().withRegion("ORD"));
48-
assertTrue(new SwiftFindFeature(session).find(container));
49+
assertTrue(new SwiftFindFeature(session, region).find(container));
4950
// Can create again regardless if exists
5051
feature.mkdir(test, new TransferStatus());
51-
new SwiftDeleteFeature(session).delete(Collections.singletonList(container), new DisabledLoginCallback(), new Delete.DisabledCallback());
52-
assertFalse(new SwiftFindFeature(session).find(container));
52+
new SwiftDeleteFeature(session, region).delete(Collections.singletonList(container), new DisabledLoginCallback(), new Delete.DisabledCallback());
53+
assertFalse(new SwiftFindFeature(session, region).find(container));
5354
}
5455

5556
@Test
@@ -70,16 +71,17 @@ public void log(final Type request, final String message) {
7071
});
7172
final Path container = new Path("/test.cyberduck.ch", EnumSet.of(Path.Type.volume, Path.Type.directory));
7273
container.attributes().setRegion("IAD");
73-
final SwiftDirectoryFeature feature = new SwiftDirectoryFeature(session, new SwiftRegionService(session), new SwiftWriteFeature(session, new SwiftRegionService(session)));
74+
final SwiftRegionService region = new SwiftRegionService(session);
75+
final SwiftDirectoryFeature feature = new SwiftDirectoryFeature(session, region, new SwiftWriteFeature(session, region));
7476
final Path parent = feature.mkdir(new Path(container, parentname, EnumSet.of(Path.Type.directory)), new TransferStatus());
7577
final Path placeholder = feature.mkdir(new Path(parent, name, EnumSet.of(Path.Type.directory)), new TransferStatus());
7678
assertTrue(put.get());
77-
assertTrue(new SwiftFindFeature(session).find(placeholder));
79+
assertTrue(new SwiftFindFeature(session, region).find(placeholder));
7880
assertTrue(new DefaultFindFeature(session).find(placeholder));
79-
assertEquals(placeholder.attributes().getChecksum(), new SwiftAttributesFinderFeature(session).find(placeholder).getChecksum());
80-
assertTrue(new SwiftObjectListService(session, new SwiftRegionService(session)).list(placeholder, new DisabledListProgressListener()).isEmpty());
81-
assertEquals(1, new SwiftObjectListService(session, new SwiftRegionService(session)).list(parent, new DisabledListProgressListener()).size());
82-
new SwiftDeleteFeature(session).delete(Arrays.asList(placeholder, parent), new DisabledLoginCallback(), new Delete.DisabledCallback());
83-
assertFalse(new SwiftFindFeature(session).find(placeholder));
81+
assertEquals(placeholder.attributes().getChecksum(), new SwiftAttributesFinderFeature(session, region).find(placeholder).getChecksum());
82+
assertTrue(new SwiftObjectListService(session, region).list(placeholder, new DisabledListProgressListener()).isEmpty());
83+
assertEquals(1, new SwiftObjectListService(session, region).list(parent, new DisabledListProgressListener()).size());
84+
new SwiftDeleteFeature(session, region).delete(Arrays.asList(placeholder, parent), new DisabledLoginCallback(), new Delete.DisabledCallback());
85+
assertFalse(new SwiftFindFeature(session, region).find(placeholder));
8486
}
8587
}

0 commit comments

Comments
 (0)