Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log being spammed when changing year preference #208

Open
LorgeN opened this issue Jan 27, 2021 · 1 comment
Open

Log being spammed when changing year preference #208

LorgeN opened this issue Jan 27, 2021 · 1 comment
Assignees
Labels
bug Something isn't working python Pull requests that update Python code

Comments

@LorgeN
Copy link
Member

LorgeN commented Jan 27, 2021

When updating the preferences (year specifically) spams the log:
image

This is most likely due to the iteration of every single existing year, and setting active to false even if it is already false. Should be resolved by adding an if statement ignoring any inactive years, and reducing the log spam quite significantly.

@LorgeN LorgeN self-assigned this Jan 27, 2021
@LorgeN LorgeN added bug Something isn't working python Pull requests that update Python code labels Jan 27, 2021
@LorgeN
Copy link
Member Author

LorgeN commented Jan 28, 2021

Appears that when saving the Preference model, a log item is forced even with the log_it=False flag, as can be seen here. I don't see any reason why it would be forced like this?

This is at least what causes the log spam, since the flag is set to false in the preference form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant