Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Never fail to launch app #179

Open
flaviotordini opened this issue Oct 11, 2023 · 6 comments
Open

[Proposal] Never fail to launch app #179

flaviotordini opened this issue Oct 11, 2023 · 6 comments

Comments

@flaviotordini
Copy link

I recently encountered an issue that prevents application startup (#178). This made me think how disastrous this scenario is when a user encounters it.

I think a design goal, if it's not already the case, should be to never fail to launch an app instance. If something goes wrong it should launch anyway, even if it is a second instance.

What do you think?

@itay-grudev
Copy link
Owner

We support that through the secondary instance flag. In essence this allows both the primary and multiple secondary instances to co-exist at the same time and you can use the sendMessage() method. See here for full documentation.

@flaviotordini
Copy link
Author

flaviotordini commented Oct 12, 2023

I think you misunderstood. I'm talking about never failing to launch because of an internal error of this library.

Basically the abortSafely method should be removed and the app should start anyway if anything goes wrong internally.

@itay-grudev
Copy link
Owner

That actually a good point.

@itay-grudev
Copy link
Owner

itay-grudev commented Oct 12, 2023

I'm working on a version 4 of the library that uses network negotiation via local sockets for single instance protection (as opposed to shared memory or lock files). It's supposed to be the version 4 of the library. I'll implement it there.

@dail8859
Copy link
Contributor

Just to put in my two cents...

It would be detrimental if there were two instances of my application ever running at the same time since they would be overriding settings and interfering with one another.

So if the functionality was added, please make it optional.

@itay-grudev
Copy link
Owner

@dail8859 That goes without saying. It's just a matter of changing the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants