Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi platforms support for RepoOutDir #1004

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TrevorTaoARM
Copy link

Add multi-platform output dir support for
arm64 and other platforms, which is used in
archive, package(deb, rpm), docker
build actions.

Signed-off-by: TrevorTaoARM [email protected]

Add multi-platform output dir support for
arm64 and other platforms, which is used in
archive, package(deb, rpm), docker
build actions.

Signed-off-by: TrevorTaoARM <[email protected]>
@TrevorTaoARM TrevorTaoARM requested a review from a team as a code owner March 23, 2022 12:44
@istio-policy-bot
Copy link

😊 Welcome @TrevorTaoARM! This is either your first contribution to the Istio release-builder repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Mar 23, 2022
@istio-testing
Copy link
Contributor

Hi @TrevorTaoARM. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine doing this short term but I think for Istio official builds we would probably only be doing both ARM and AMD at once, so we may need more work there in that regard

@howardjohn
Copy link
Member

Actually this would mean that users on non-linux/amd64 can no longer build a proper release. For example, someone running on OSX now gets a osx build which is not what we want. The build platform != target platform IMO

@ericvn
Copy link

ericvn commented Mar 23, 2022

Doing some testing with MacOS as John mentioned, but running into another issue that I need to fix first :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants