-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi platforms support for RepoOutDir #1004
base: master
Are you sure you want to change the base?
Conversation
Add multi-platform output dir support for arm64 and other platforms, which is used in archive, package(deb, rpm), docker build actions. Signed-off-by: TrevorTaoARM <[email protected]>
😊 Welcome @TrevorTaoARM! This is either your first contribution to the Istio release-builder repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @TrevorTaoARM. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine doing this short term but I think for Istio official builds we would probably only be doing both ARM and AMD at once, so we may need more work there in that regard
Actually this would mean that users on non-linux/amd64 can no longer build a proper release. For example, someone running on OSX now gets a osx build which is not what we want. The build platform != target platform IMO |
Doing some testing with MacOS as John mentioned, but running into another issue that I need to fix first :(. |
Add multi-platform output dir support for
arm64 and other platforms, which is used in
archive, package(deb, rpm), docker
build actions.
Signed-off-by: TrevorTaoARM [email protected]