Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waypoint usage doc references label that doesn't exist #16168

Closed
therealmitchconnors opened this issue Jan 13, 2025 · 1 comment · Fixed by #16184
Closed

waypoint usage doc references label that doesn't exist #16168

therealmitchconnors opened this issue Jan 13, 2025 · 1 comment · Fixed by #16184
Assignees
@craigbox

Comments

@therealmitchconnors
Copy link
Contributor

At docs/ambient/usage/waypoint the waypoint usage doc says:

Note the Gateway resource has the istio-waypoint label set to gatewayClassName which indicates it is a waypoint provided by Istio.

However, no such label exists. I think perhaps what is intended is:

Note the Gateway resource has the spec.gatewayClassName set to istio-waypoint which indicates it is a waypoint provided by Istio.
@craigbox craigbox mentioned this issue Jan 20, 2025
Merged
@craigbox
Copy link
Contributor

blame is me

penance

@craigbox craigbox self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craigbox craigbox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update waypoint gatewayClassName description istio/istio.io
2 participants
@craigbox @therealmitchconnors