Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE cniBinDir documentation removed #16056

Open
howardjohn opened this issue Dec 5, 2024 · 2 comments
Open

GKE cniBinDir documentation removed #16056

howardjohn opened this issue Dec 5, 2024 · 2 comments
Assignees

Comments

@howardjohn
Copy link
Member

istio/istio#53849 (comment) -- refactoring removed any documentation of cniBinDir setting for GKE. https://istio.io/latest/docs/ambient/install/platform-prerequisites/#google-kubernetes-engine-gke is missing it and https://istio.io/latest/docs/setup/additional-setup/cni/ links only there

cc @bleggett

@bleggett
Copy link
Contributor

bleggett commented Dec 5, 2024

This is already fixed (the right way) in #16035 but wasn't backported.

I'll do a 1.24 only tweak docs backport that will be superceded in the next release with the platform profile anyway - that will automatically also cover this case (which only happens today if you aren't using either of the two recommended install methods of istioctl or helm)

@bleggett
Copy link
Contributor

bleggett commented Dec 5, 2024

There are probably other template-install-only gotchas we have, but we do not and have not ever really consistently documented them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants