-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[Isaac Sim 6.0] Updates torch to 2.9.0+cu13 #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/isaacsim-6-0
Are you sure you want to change the base?
[Isaac Sim 6.0] Updates torch to 2.9.0+cu13 #4001
Conversation
Greptile OverviewGreptile SummaryUpdates PyTorch from 2.7.0+cu128 to 2.9.0+cu130 to align with Isaac Sim 6.0 requirements, unifying the torch version across all architectures (previously aarch64 used 2.9.0 while x86_64 used 2.7.0). Critical Issues Found:
Impact:
Confidence Score: 0/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR as Pull Request #4001
participant Docs as Documentation Files
participant Scripts as Install Scripts
participant Setup as setup.py
participant User as End User
Dev->>PR: Update PyTorch to 2.9.0+cu130
PR->>Docs: Update installation.rst files
Note over Docs: pip_installation.rst<br/>isaaclab_pip_installation.rst<br/>quickstart.rst<br/>newton installation.rst
PR->>Scripts: Update isaaclab.sh & .bat
Note over Scripts: Change CUDA tag cu128→cu130<br/>Change torch 2.7.0→2.9.0
PR->>Setup: Update setup.py requirements
Note over Setup: torch>=2.9<br/>PYTORCH_INDEX_URL cu130
User->>Docs: Follow installation guide
Docs-->>User: pip install torch==2.9.0 --index-url whl30
Note over User,Docs: ❌ BROKEN: Missing /cu130<br/>404 Not Found Error
User->>Scripts: Run isaaclab.sh --install
Scripts->>User: ✓ Installs torch 2.9.0+cu130
Note over User: Installation succeeds via script<br/>but fails via manual docs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (3)
-
docs/source/setup/installation/isaaclab_pip_installation.rst, line 28 (link)syntax: comment says CUDA 12.8 but should say CUDA 13.0 to match the cu130 version
-
docs/source/setup/installation/isaaclab_pip_installation.rst, line 66 (link)syntax: outdated PyTorch version in comment - should be 2.9.0, not 2.7.0
-
docs/source/setup/installation/isaaclab_pip_installation.rst, line 73 (link)syntax: outdated PyTorch version - should be 2.9.0, not 2.7.0
7 files reviewed, 8 comments
| .. code-block:: none | ||
| pip install torch==2.7.0 torchvision==0.22.0 --index-url https://download.pytorch.org/whl/cu128 | ||
| pip install torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: malformed PyTorch index URL - missing /cu130 after whl
| pip install torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 | |
| pip install torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl/cu130 |
| .. code-block:: bash | ||
| pip install -U torch==2.7.0 torchvision==0.22.0 --index-url https://download.pytorch.org/whl/cu128 | ||
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: malformed PyTorch index URL - missing /cu130 after whl
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 | |
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl/cu130 |
| .. code-block:: bash | ||
| pip install -U torch==2.7.0 torchvision==0.22.0 --index-url https://download.pytorch.org/whl/cu128 | ||
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: malformed PyTorch index URL - missing /cu130 after whl
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 | |
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl/cu130 |
| .. code-block:: bash | ||
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl/cu130 | ||
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: malformed PyTorch index URL - missing /cu130 after whl
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 | |
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl/cu130 |
docs/source/setup/quickstart.rst
Outdated
| .. code-block:: bash | ||
| pip install -U torch==2.7.0 torchvision==0.22.0 --index-url https://download.pytorch.org/whl/cu128 | ||
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: malformed PyTorch index URL - missing /cu130 after whl
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl30 | |
| pip install -U torch==2.9.0 torchvision==0.24.0 --index-url https://download.pytorch.org/whl/cu130 |
| import torch | ||
| from datetime import datetime | ||
|
|
||
| from rsl_rl.runners import DistillationRunner, OnPolicyRunner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this linter change?
Signed-off-by: Kelly Guo <[email protected]>
Removed redundant environment variable export for ISAACSIM_ACCEPT_EULA. Signed-off-by: Kelly Guo <[email protected]>
Added dependencies to resolve pip errors. Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Removed unnecessary dependencies to resolve pip errors. Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Description
Updates torch to 2.9.0, requiring cuda 13 and driver 580+
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there