From 48c8241144e2deaab493f12eaabcc70c6b2f2188 Mon Sep 17 00:00:00 2001 From: Narendra Dahile Date: Tue, 30 Sep 2025 23:49:09 -0700 Subject: [PATCH 1/3] Fix command formation --- isaaclab.bat | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/isaaclab.bat b/isaaclab.bat index 0a6cd9f7361..5a564fed6c9 100644 --- a/isaaclab.bat +++ b/isaaclab.bat @@ -511,32 +511,20 @@ if "%arg%"=="-i" ( call :extract_python_exe echo [INFO] Using python from: !python_exe! REM Loop through all arguments - mimic shift - set "allArgs=" - for %%a in (%*) do ( - REM Append each argument to the variable, skip the first one - if defined skip ( - set "allArgs=!allArgs! %%a" - ) else ( - set "skip=1" - ) + for /f "tokens=1,* delims= " %%a in ("%*") do ( + set "args_without_first=%%b" ) - call !python_exe! !allArgs! + call !python_exe! !args_without_first! goto :end ) else if "%arg%"=="--python" ( rem run the python provided by Isaac Sim call :extract_python_exe echo [INFO] Using python from: !python_exe! REM Loop through all arguments - mimic shift - set "allArgs=" - for %%a in (%*) do ( - REM Append each argument to the variable, skip the first one - if defined skip ( - set "allArgs=!allArgs! %%a" - ) else ( - set "skip=1" - ) + for /f "tokens=1,* delims= " %%a in ("%*") do ( + set "args_without_first=%%b" ) - call !python_exe! !allArgs! + call !python_exe! !args_without_first! goto :end ) else if "%arg%"=="-s" ( rem run the simulator exe provided by isaacsim From 9742af08d64c4b0d958a9af585f486b8955eb395 Mon Sep 17 00:00:00 2001 From: Narendra Dahile Date: Tue, 30 Sep 2025 23:57:45 -0700 Subject: [PATCH 2/3] Added name in Contributors list --- CONTRIBUTORS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index ea0da7c376a..be6c389e2ba 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -102,6 +102,7 @@ Guidelines for modifications: * Miguel Alonso Jr * Mingyu Lee * Muhong Guo +* Narendra Dahile * Neel Anand Jawale * Nicola Loi * Norbert Cygiert From 3ee1971e38b627f28af07f55feb12cc4ed596bd0 Mon Sep 17 00:00:00 2001 From: Narendra Dahile Date: Wed, 1 Oct 2025 00:16:06 -0700 Subject: [PATCH 3/3] rename veriable --- isaaclab.bat | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/isaaclab.bat b/isaaclab.bat index 5a564fed6c9..f47364e00b3 100644 --- a/isaaclab.bat +++ b/isaaclab.bat @@ -512,9 +512,9 @@ if "%arg%"=="-i" ( echo [INFO] Using python from: !python_exe! REM Loop through all arguments - mimic shift for /f "tokens=1,* delims= " %%a in ("%*") do ( - set "args_without_first=%%b" + set "allArgs=%%b" ) - call !python_exe! !args_without_first! + call !python_exe! !allArgs! goto :end ) else if "%arg%"=="--python" ( rem run the python provided by Isaac Sim @@ -522,9 +522,9 @@ if "%arg%"=="-i" ( echo [INFO] Using python from: !python_exe! REM Loop through all arguments - mimic shift for /f "tokens=1,* delims= " %%a in ("%*") do ( - set "args_without_first=%%b" + set "allArgs=%%b" ) - call !python_exe! !args_without_first! + call !python_exe! !allArgs! goto :end ) else if "%arg%"=="-s" ( rem run the simulator exe provided by isaacsim