-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.OutOfMemoryException when reading corrupt Word document #40
Comments
I'll try to find some time to remember how SharpFuzz worked (last time I tried I had to run it on Ubuntu as it didn't work on Windows. That was quite a while ago though) |
@Numpsy Looks like this works OK in 3.0, but 3.0 won't even allow getting as far as what causes the problem for 2.4 anyway. Essentially the header is corrupt (it states there are more difat sectors than what there actually are) but the approach to validating the file in 2.4 assumes the header is valid, or otherwise throws an OOM exception. I'm tempted to close this as it's already fixed in 3.0 and realistically unfixable for 2.4 (since fixing it would essentially entail a rewrite, and that's what 3.0 is). I could perhaps expose some mechanisms to corrupt the CFB data in various ways, but I'd rather do that as a wider task of coverage and fuzzing than worry about this specific case/file. WDYT? |
Considering this one some more. By inspection for 3.0:
So, I think 3.0 is fine on this front despite the file here not being able to excercise any of those conditions, but I will review to replace the invalid operation exception with something more appropriate. |
Related to #30, but blowing up in a different location:
if you try to open the file out_of_memory_2.zip (generated by SharpFuzz) with the current OpenMcdf, you get a System.OutOfMemoryException with the call stack:
The text was updated successfully, but these errors were encountered: