Review feedback

Author: lukasfrank

api/compute/v1alpha1/machinereservation_types.go

@@ -12,12 +12,13 @@ import (
 // ReservationSpec defines the desired state of Reservation
 type ReservationSpec struct {
 	Pools     []corev1.LocalObjectReference `json:"pools"`
-	Resources corev1alpha1.ResourceList     `json:"capabilities,omitempty"`
+	Resources corev1alpha1.ResourceList     `json:"resources,omitempty"`
 }
 
 // ReservationStatus defines the observed state of Reservation
 type ReservationStatus struct {
-	Pools []ReservationPoolStatus `json:"pools,omitempty"`
+	Pools      []ReservationPoolStatus `json:"pools,omitempty"`
+	Conditions []ReservationCondition  `json:"conditions,omitempty"`
 }
 
 // ReservationState is the state of a Reservation.
@@ -33,6 +34,25 @@ const (
 	ReservationStateRejected ReservationState = "Rejected"
 )
 
+// ReservationConditionType is a type a ReservationCondition can have.
+type ReservationConditionType string
+
+// ReservationCondition is one of the conditions of a volume.
+type ReservationCondition struct {
+	// Type is the type of the condition.
+	Type ReservationConditionType `json:"type"`
+	// Status is the status of the condition.
+	Status corev1.ConditionStatus `json:"status"`
+	// Reason is a machine-readable indication of why the condition is in a certain state.
+	Reason string `json:"reason"`
+	// Message is a human-readable explanation of why the condition has a certain reason / state.
+	Message string `json:"message"`
+	// ObservedGeneration represents the .metadata.generation that the condition was set based upon.
+	ObservedGeneration int64 `json:"observedGeneration,omitempty"`
+	// LastTransitionTime is the last time the status of a condition has transitioned from one state to another.
+	LastTransitionTime metav1.Time `json:"lastTransitionTime,omitempty"`
+}
+
 type ReservationPoolStatus struct {
 	Name  string           `json:"ref,omitempty"`
 	State ReservationState `json:"state,omitempty"`

internal/apis/compute/machinereservation_types.go

@@ -17,7 +17,8 @@ type ReservationSpec struct {
 
 // ReservationStatus defines the observed state of Reservation
 type ReservationStatus struct {
-	Pools []ReservationPoolStatus
+	Pools      []ReservationPoolStatus
+	Conditions []ReservationCondition
 }
 
 // ReservationState is the state of a Reservation.
@@ -38,6 +39,25 @@ type ReservationPoolStatus struct {
 	State ReservationState
 }
 
+// ReservationConditionType is a type a ReservationCondition can have.
+type ReservationConditionType string
+
+// ReservationCondition is one of the conditions of a volume.
+type ReservationCondition struct {
+	// Type is the type of the condition.
+	Type ReservationConditionType
+	// Status is the status of the condition.
+	Status corev1.ConditionStatus
+	// Reason is a machine-readable indication of why the condition is in a certain state.
+	Reason string
+	// Message is a human-readable explanation of why the condition has a certain reason / state.
+	Message string
+	// ObservedGeneration represents the .metadata.generation that the condition was set based upon.
+	ObservedGeneration int64
+	// LastTransitionTime is the last time the status of a condition has transitioned from one state to another.
+	LastTransitionTime metav1.Time
+}
+
 // +genclient
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object