PR review

lukasfrank · lukasfrank · commit 5ce43e727bb7 · 2025-07-08T09:36:56.000+02:00
diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml
@@ -7,7 +7,6 @@ on:
   push:
     branches:
     - main
-    - lukasfrank:feat/reservations
     tags:
     - v*
     paths-ignore:
@@ -88,7 +87,7 @@ jobs:
         version: latest
         endpoint: builders # self-hosted
     - name: Login to GHCR
-#      if: github.event_name != 'pull_request'
+      if: github.event_name != 'pull_request'
       uses: docker/login-action@v3
       with:
         registry: ghcr.io
@@ -100,7 +99,7 @@ jobs:
       with:
         context: .
         platforms: linux/amd64,linux/arm64
-#        push: ${{ github.event_name != 'pull_request' }}
+        push: ${{ github.event_name != 'pull_request' }}
         tags: ${{ steps.meta.outputs.tags }}
         labels: ${{ steps.meta.outputs.labels }}
         target: ${{ matrix.image.target }}
diff --git a/api/compute/v1alpha1/machinereservation_types.go b/api/compute/v1alpha1/machinereservation_types.go
@@ -13,6 +13,7 @@ import (
 type ReservationSpec struct {
 	Pools     []corev1.LocalObjectReference `json:"pools"`
 	Resources corev1alpha1.ResourceList     `json:"resources,omitempty"`
+	// TODO we might want to add a weight to indicate preference/priority
 }
 
 // ReservationStatus defines the observed state of Reservation
diff --git a/iri/apis/machine/v1alpha1/api.pb.go b/iri/apis/machine/v1alpha1/api.pb.go

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ import (`
`13`	`13`	`type ReservationSpec struct {`
`14`	`14`	Pools []corev1.LocalObjectReference `json:"pools"`
`15`	`15`	Resources corev1alpha1.ResourceList `json:"resources,omitempty"`
	`16`	`+ // TODO we might want to add a weight to indicate preference/priority`
`16`	`17`	`}`
`17`	`18`
`18`	`19`	`// ReservationStatus defines the observed state of Reservation`