fix errors like parse error still printed in color when -plaintext is set

Author: irmen

codeCore/src/prog8/code/core/IErrorReporter.kt

@@ -13,4 +13,6 @@ interface IErrorReporter {
     }
 
     fun noErrorForLine(position: Position): Boolean
+
+    fun print_single_error(errormessage: String)
 }

codeGenCpu6502/test/Dummies.kt

@@ -68,6 +68,7 @@ internal class ErrorReporterForTests(private val throwExceptionAtReportIfErrors:
 
     override fun noErrors(): Boolean  = errors.isEmpty()
     override fun noErrorForLine(position: Position) = !errors.any { ":${position.line}:" in it }
+    override fun print_single_error(errormessage: String) { /* prints nothing in tests */ }
 
     override fun report() {
         infos.forEach { println("UNITTEST COMPILATION REPORT: INFO: $it") }

codeGenIntermediate/test/Dummies.kt

@@ -66,6 +66,7 @@ internal class ErrorReporterForTests(private val throwExceptionAtReportIfErrors:
 
     override fun noErrors(): Boolean  = errors.isEmpty()
     override fun noErrorForLine(position: Position) = !errors.any { ":${position.line}:" in it }
+    override fun print_single_error(errormessage: String) { /* prints nothing in tests */ }
 
     override fun report() {
         infos.forEach { println("UNITTEST COMPILATION REPORT: INFO: $it") }

compiler/src/prog8/compiler/Compiler.kt

@@ -200,10 +200,7 @@ fun compileProgram(args: CompilerArguments): CompilationResult? {
         }
         return CompilationResult(resultingProgram!!, ast, compilationOptions, importedFiles)
     } catch (px: ParseError) {
-        System.out.flush()
-        System.err.print("\n\u001b[91m")  // bright red
-        System.err.println("${px.position.toClickableStr()} parse error: ${px.message}".trim())
-        System.err.print("\u001b[0m")  // reset
+        args.errors.print_single_error("${px.position.toClickableStr()} parse error: ${px.message}".trim())
     } catch (ac: ErrorsReportedException) {
         if(args.printAst1 && resultingProgram!=null) {
             println("\n*********** COMPILER AST *************")
@@ -220,32 +217,17 @@ fun compileProgram(args: CompilerArguments): CompilationResult? {
             }
         }
         if(!ac.message.isNullOrEmpty()) {
-            System.out.flush()
-            System.err.print("\n\u001b[91m")  // bright red
-            System.err.println(ac.message)
-            System.err.print("\u001b[0m")  // reset
+            args.errors.print_single_error(ac.message!!)
         }
     } catch (nsf: NoSuchFileException) {
-        System.out.flush()
-        System.err.print("\n\u001b[91m")  // bright red
-        System.err.println("File not found: ${nsf.message}")
-        System.err.print("\u001b[0m")  // reset
+        args.errors.print_single_error("File not found: ${nsf.message}")
     } catch (ax: AstException) {
-        System.out.flush()
-        System.err.print("\n\u001b[91m")  // bright red
-        System.err.println(ax.toString())
-        System.err.print("\u001b[0m")  // reset
+        args.errors.print_single_error(ax.toString())
     } catch (x: Exception) {
-        print("\n\u001b[91m")  // bright red
-        println("\n* internal error *")
-        print("\u001b[0m")  // reset
-        System.out.flush()
+        args.errors.print_single_error("\ninternal error")
         throw x
     } catch (x: NotImplementedError) {
-        print("\n\u001b[91m")  // bright red
-        println("\n* internal error: missing feature/code *")
-        print("\u001b[0m")  // reset
-        System.out.flush()
+        args.errors.print_single_error("\ninternal error: missing feature/code")
         throw x
     }
 

compiler/src/prog8/compiler/ErrorReporter.kt

@@ -95,6 +95,12 @@ internal class ErrorReporter(val colors: IConsoleColors): IErrorReporter {
     override fun noErrors() = messages.none { it.severity==MessageSeverity.ERROR }
     override fun noErrorForLine(position: Position) = !messages.any { it.position.line==position.line && it.severity!=MessageSeverity.INFO }
 
+    override fun print_single_error(errormessage: String) {
+        System.out.flush()
+        colors.error(System.err)
+        System.err.println(errormessage)
+        colors.normal(System.err)
+    }
 
     interface IConsoleColors {
         fun error(printer: PrintStream)

compiler/test/helpers/ErrorReporterForTests.kt

@@ -33,6 +33,7 @@ internal class ErrorReporterForTests(private val throwExceptionAtReportIfErrors:
 
     override fun noErrors(): Boolean  = errors.isEmpty()
     override fun noErrorForLine(position: Position) = !errors.any { ":${position.line}:" in it }
+    override fun print_single_error(errormessage: String) { /* prints nothing in tests */ }
 
     override fun report() {
         infos.forEach { println("UNITTEST COMPILATION REPORT: INFO: $it") }

docs/source/todo.rst

@@ -1,6 +1,8 @@
 TODO
 ====
 
+- can goto array[idx] be optimized (array as @nosplit) ?
+
 ...
 
 

examples/test.p8

@@ -6,59 +6,6 @@
 main {
 
     sub start() {
-        uword buffer = memory("buffer", 100, 0)
-        uword buffer2 = memory("buffer2", 100, 0)
-        sys.memset(buffer, 100, 0)
-        sys.memset(buffer2, 100, 0)
-        str contents = petscii:"<- this is the contents of the file ->"
+        a=33
 
-        txt.print("string size=")
-        txt.print_uw(len(contents))
-        txt.nl()
-        txt.print(contents)
-        txt.nl()
-        txt.print_ubhex(contents[3],true)
-        txt.spc()
-        txt.print_ubhex(contents[4],true)
-        txt.spc()
-        txt.print_ubhex(contents[5],true)
-        txt.nl()
-        txt.nl()
-
-        diskio.save("@:testfile", contents, len(contents))
-        uword end_address = diskio.load_raw("testfile", buffer)
-        uword size = end_address - buffer
-        txt.print("file size=")
-        txt.print_uw(size)
-        txt.nl()
-        txt.print_uwhex(peekw(buffer), true)
-        txt.spc()
-        txt.print(buffer+2)
-        txt.nl()
-        txt.print_ubhex(buffer[2+3],true)
-        txt.spc()
-        txt.print_ubhex(buffer[2+4],true)
-        txt.spc()
-        txt.print_ubhex(buffer[2+5],true)
-        txt.nl()
-        txt.nl()
-
-        diskio.f_open("testfile")
-        size = diskio.f_read_all(buffer2)
-        diskio.f_close()
-        txt.print("file size=")
-        txt.print_uw(size)
-        txt.nl()
-        txt.print_uwhex(peekw(buffer2), true)
-        txt.spc()
-        txt.print(buffer2+2)
-        txt.nl()
-        txt.print_ubhex(buffer2[2+3],true)
-        txt.spc()
-        txt.print_ubhex(buffer2[2+4],true)
-        txt.spc()
-        txt.print_ubhex(buffer2[2+5],true)
-        txt.nl()
-        txt.nl()
-    }
 }