Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a support for a .button class #7

Open
goodpixels opened this issue Apr 22, 2016 · 5 comments
Open

Add a support for a .button class #7

goodpixels opened this issue Apr 22, 2016 · 5 comments

Comments

@goodpixels
Copy link

goodpixels commented Apr 22, 2016

Sometimes you want to style your links as if they were buttons - and it would be handy to allow users to assign a class which would inherit button styling, so you can write this:

<a href="http://google.com" class="button">Click</a>

This should render the same as this:

<button>Click</button>

Currently you have to @extend, but I am not sure if it's the best idea, because it affects the compile time.

@ireade
Copy link
Owner

ireade commented Apr 22, 2016

Thanks for the suggestion, sounds like a good idea

@michaelmano
Copy link

Just some input regarding this.

This project is about resetting form elements, not styling them.

I would keep it simple and just remove all styles from the button element and let the user style their elements.

.Button,
button,
input[type="button"],
input[type="submit"] {
    /* whatever they desire */
}

Though lets be honest, Its been years and this wont happen.

@ireade
Copy link
Owner

ireade commented Jun 23, 2018

Hey guys!

Sorry about the delay, I haven't had much time to dedicate to this project in ages.

I've been thinking about this and I'm not sure that adding a class here would be best. As @michaelmano said:

This project is about resetting form elements, not styling them.

I think adding a .button class will move this away from resetting form elements, to trying to style form elements. I think that extending the .button class is a good alternative. Although it will have slightly longer compile times, it wouldn't be so significant.

Let me know what you guys think.

@michaelmano
Copy link

@ireade I would love to see this project grow and will help out if you don't mind contributors.

@ireade
Copy link
Owner

ireade commented Jun 27, 2018

@michaelmano Sure I'd be open to that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants