Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header to gossiped receipts #421

Closed
Tracked by #417
bgins opened this issue Nov 10, 2023 · 1 comment
Closed
Tracked by #417

Add header to gossiped receipts #421

bgins opened this issue Nov 10, 2023 · 1 comment
Assignees
@bgins
Labels
dx Developer experience applications and improvements networking Features, functionality involving networking

Comments

@bgins
Copy link
Contributor

bgins commented Nov 10, 2023 •
edited
Loading

Summary

Problem

Gossiped receipts will not be sent by libp2p if they are duplicates.

Impact

Receipts are not sent on workflow replays.

Solution

Add a header with a nonce to make the messages we gossip unique. We may use the header for other purposes in the future.
@bgins bgins added networking Features, functionality involving networking dx Developer experience applications and improvements labels Nov 10, 2023
@bgins bgins mentioned this issue Nov 15, 2023
Merged
3 tasks
bgins added a commit that referenced this issue Nov 15, 2023
@bgins @zeeshanlakhani
refactor: Add Gossipsub Message wrapper (#436)
bfaaff6 
# Description

This PR implements the following changes:

- [x] Add gosssipsub message wrapper
- [x] Rename `store_and_notify` to `publish_and_notify`

The message wrapper includes a header with a nonce to force the gossip
of duplicate receipts. We will likely expand on the header in future
work and make the nonce optional.

## Link to issue

Implements #421.

## Type of change

- [x] Refactor (non-breaking change that updates existing functionality)

## Test plan (required)

We've added a unit test to roundtrip a gossiped message to bytes and
back again. We also have a gossip notifications integration test to
confirm messages are still sent.

---------

Co-authored-by: Zeeshan Lakhani <[email protected]>
@zeeshanlakhani
Copy link
Contributor

Completed as part of #417.

@bgins bgins mentioned this issue Nov 16, 2023
Merged
20 tasks
zeeshanlakhani added a commit that referenced this issue Nov 29, 2023
@bgins @zeeshanlakhani
refactor: Add Gossipsub Message wrapper (#436)
59383e5 
# Description

This PR implements the following changes:

- [x] Add gosssipsub message wrapper
- [x] Rename `store_and_notify` to `publish_and_notify`

The message wrapper includes a header with a nonce to force the gossip
of duplicate receipts. We will likely expand on the header in future
work and make the nonce optional.

## Link to issue

Implements #421.

## Type of change

- [x] Refactor (non-breaking change that updates existing functionality)

## Test plan (required)

We've added a unit test to roundtrip a gossiped message to bytes and
back again. We also have a gossip notifications integration test to
confirm messages are still sent.

---------

Co-authored-by: Zeeshan Lakhani <[email protected]>
@bgins bgins self-assigned this Nov 29, 2023
bgins added a commit that referenced this issue Nov 29, 2023
@bgins @hugomrdias
jsonrpc-feature returned (#417)
ac9167c 
## Description

Includes:
  - re-purposing of feature flags 
    * metrics is always a thing (on) 
    * monitoring is the gated feature 
    * The websocket-server flag is gone, we only gate push notifications
  - JSON-RPC setup and RPC method register
  - Prometheus exposition format to JSON parser

Other features and other fixes:

- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354 
- [x] #409
- [x] #425 
- [x] #426
- [x] #429 
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451 
- [x] #456

---------

Signed-off-by: Brian Ginsburg <[email protected]>
Signed-off-by: Zeeshan Lakhani <[email protected]>
Co-authored-by: Brian Ginsburg <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
bgins added a commit that referenced this issue Nov 29, 2023
@bgins @hugomrdias
feat: Add JSON-PRC API (#417)
9b67136 
Includes:
  - re-purposing of feature flags
    * metrics is always a thing (on)
    * monitoring is the gated feature
    * The websocket-server flag is gone, we only gate push notifications
  - JSON-RPC setup and RPC method register
  - Prometheus exposition format to JSON parser

Other features and other fixes:

- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354
- [x] #409
- [x] #425
- [x] #426
- [x] #429
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451
- [x] #456

---------

Signed-off-by: Brian Ginsburg <[email protected]>
Signed-off-by: Zeeshan Lakhani <[email protected]>
Co-authored-by: Brian Ginsburg <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgins bgins

Labels
dx Developer experience applications and improvements networking Features, functionality involving networking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeeshanlakhani @bgins