You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
15s timeout on cold cache might lead to undesired denial of service if content is only announced to IPNI at cid.contact, and either client or server are under load so receiving response takes more than 15s
Solution
I think we should expose http routing client metrics to see if/when things fail, and make things configurable (at least the routing timeout), and use our infra to adjust the default based on real world performance:
expose timeout as a configuration setting, allowing us to fine-tune it on ipfs.io infra
Problem
Seems that we have hardcoded some settings related to delegated routing over HTTP
rainbow/setup.go
Line 273 in 19723fe
15s timeout on cold cache might lead to undesired denial of service if content is only announced to IPNI at cid.contact, and either client or server are under load so receiving response takes more than 15s
Solution
I think we should expose http routing client metrics to see if/when things fail, and make things configurable (at least the routing timeout), and use our infra to adjust the default based on real world performance:
but we don't seem to expose
routing_http_client_latency
on http://127.0.0.1:8091/debug/metrics/prometheusThe text was updated successfully, but these errors were encountered: