Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake configuration error #301

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix cmake configuration error #301

merged 1 commit into from
Sep 29, 2023

Conversation

ffoulkes
Copy link
Contributor

  • As the result of the most recent changes, the cmake configuration step fails because the gflags::gflags_shared target is undefined. Address this by finding the gflags package in the top-level cmake listfile.

@ffoulkes
Fix cmake configuration error
408e269 
- As the result of the most recent changes, the cmake configuration
  step fails because the gflags::gflags_shared target is undefined.
  Address this by finding the gflags package in the top-level cmake
  listfile.

Signed-off-by: Derek G Foster <[email protected]>
@ffoulkes ffoulkes requested a review from satish153 September 29, 2023 19:22
5abeel
5abeel approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nupuruttarwar
nupuruttarwar approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit fe9fc27 into main Sep 29, 2023
4 checks passed
@ffoulkes ffoulkes deleted the google-packages branch September 29, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5abeel 5abeel 5abeel approved these changes

@nupuruttarwar nupuruttarwar nupuruttarwar approved these changes

@satish153 satish153 Awaiting requested review from satish153

@n-sandeep n-sandeep Awaiting requested review from n-sandeep n-sandeep is a code owner

@vsureshkumarp vsureshkumarp Awaiting requested review from vsureshkumarp vsureshkumarp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffoulkes @nupuruttarwar @5abeel