Modularize protobuf compile functions #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move generate_proto_files() and generate_grpc_files() function definitions to ProtobufCompile.cmake. Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
requested review from
nupuruttarwar,
n-sandeep,
vsureshkumarp and
5abeel
as code owners
Signed-off-by: Derek G Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a physical refactoring -- moving an option and two function definitions to an include file. The changes were:
The renaming stems from the need to make it clear that we use the host protobuf compiler in the cross-compilation environment (which has both host (x86) and target (arm) Stratum dependencies).