Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify nature of es2k setup guide #281

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Clarify nature of es2k setup guide #281

merged 1 commit into from
Sep 13, 2023

Conversation

ffoulkes
Copy link
Contributor

  • Say at the top of the document that it is for a host build.

  • Rewrite the "Install P4 SDE" section to account for its vagueness and disclaim responsiblity for documenting the setup procedures for the ES2K.

- Say at the top of the document that it is for a host build.

- Rewrite the "Install P4 SDE" section to account for its
  vagueness and disclaim responsiblity for documenting the
  setup procedures for the ES2K.

Signed-off-by: Derek G Foster <[email protected]>
@ffoulkes
Copy link
Contributor Author

This is a step in the right direction. It is not the final solution. But it provides the reader with answers to two of the most pressing questions, and it does so now.

Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@n-sandeep n-sandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit 61e7816 into main Sep 13, 2023
4 checks passed
@ffoulkes ffoulkes deleted the es2k-guide-edits branch September 13, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants