You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PrepareVlanPushTableEntry() function encodes the vlan_id parameter as as single byte in both the mod_blob_ptr match key and the vlan_id action parameter.
VLAN identifiers are bit<12>.
If this is intentional, the code should contain comments that:
Acknowledge the truncation,
State that it is intentional, and
Explain why this is the correct thing to do.
If this is unintentional, it is a bug and should be fixed.
The unit test should also be updated.
Note
Address both DPDK and ES2K variants.
The unit tests should expect, and test with, a 12-bit input value.
The text was updated successfully, but these errors were encountered:
ffoulkes
changed the title
[ovsp4rt] PrepareVlanPushTableEntry truncates vlan_id to bit<8>
[ovsp4rt] PrepareVlanPushTableEntry truncates vlan_id to 8 bits
Aug 12, 2024
The
PrepareVlanPushTableEntry()
function encodes thevlan_id
parameter as as single byte in both themod_blob_ptr
match key and thevlan_id
action parameter.VLAN identifiers are bit<12>.
If this is intentional, the code should contain comments that:
If this is unintentional, it is a bug and should be fixed.
The unit test should also be updated.
Note
The text was updated successfully, but these errors were encountered: