Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate programming for forwarding tables #89

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

nupuruttarwar
Copy link
Contributor

In LNW_v2, FDB entries are programmed by OVS sidecar when the MAC learning happens. It's not required to program l2_fwd_tx_table and l2_fwd_rx_table through krnlmon for new neighbor netlink message for every RIF interface to avoid duplication

In LNW_v2, FDB entries are programmed by OVS sidecar when the MAC learning
happens. It's not required to program l2_fwd_tx_table and l2_fwd_rx_table
through krnlmon for new neighbor netlink message for every RIF interface
to avoid duplication

Signed-off-by: nupuruttarwar <[email protected]>
@nupuruttarwar nupuruttarwar marked this pull request as ready for review March 12, 2024 18:58
@5abeel
Copy link
Collaborator

5abeel commented Mar 12, 2024

Please use a descriptive title for PR (and avoid company-internal numbers indicating bug number)

@nupuruttarwar nupuruttarwar changed the title Bug fix for HSD 16022829202 Remove duplicate programming for forwarding tables from krnlmon Mar 12, 2024
@nupuruttarwar
Copy link
Contributor Author

Please use a descriptive title for PR (and avoid company-internal numbers indicating bug number)

Done

Copy link
Contributor

@ffoulkes ffoulkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes
Copy link
Contributor

Nit: Krnlmon has its own repository, so it isn't necessary to say "for krnlmon" in the title.

@nupuruttarwar nupuruttarwar changed the title Remove duplicate programming for forwarding tables from krnlmon Remove duplicate programming for forwarding tables Mar 13, 2024
@nupuruttarwar nupuruttarwar merged commit 3d0b0e1 into main Apr 2, 2024
4 checks passed
@nupuruttarwar nupuruttarwar deleted the bug_fix branch April 2, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants