Krnlmon fixes for LAG and ECMP defects #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-sandeep
requested review from
ffoulkes,
nupuruttarwar and
vsureshkumarp
as code owners
ffoulkes
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
I think you've specified the wrong key at line 161 in es2k/switch_pd_lag.c.
I don't want to block the PR, so I'm going to approve it on the assumption that you will correct the error before merging it.
If it isn't an error -- if you really did intend to use a different identifier -- please add a comment saying that this is intentional (and why). Otherwise, some future maintainer is going to think it's a bug and "fix" it. (I know I would.) 🙂
Modify p4 program mapping file with correct table, key and action names Signed-off-by: Sandeep N <[email protected]>
n-sandeep
force-pushed
the
lnw_v2_fixes
branch
from
aa129b9 to
a6ef227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify p4 program mapping file with correct table, key and action names