Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate if profiling upload failed #34

Open
coreylight opened this issue Feb 10, 2018 · 1 comment
Open

Indicate if profiling upload failed #34

coreylight opened this issue Feb 10, 2018 · 1 comment
Labels

Comments

@coreylight
Copy link
Contributor

coreylight commented Feb 10, 2018

At times getting the error: "Download profiling data => "The specified key does not exist.""
https://iopipe.slack.com/archives/C6Q4HSLKD/p1518276447000024

Profiler should indicate if upload failed, so that there are no file misses.

@coreylight coreylight added the bug label Feb 10, 2018
@pselle pselle changed the title Download profiling data => "The specified key does not exist." Indicate if profiling upload failed Feb 13, 2018
@ewindisch
Copy link
Contributor

The upload may fail for an object but our API does not know this as it bases the presence of profiling data based on if the plugin is enabled or not.

Two solutions are apparent to me:

  • Mark the profiler as disabled if the profile upload fails
  • Indicate in the data that the upload filed, but that the plugin was enabled.

I do not like the first solution as it does not allow us to detect failures, it would only remove visibility of the existence of an error.

With moving to using JWTs for uploading profile links, we can simply not include the JWT link if we know the upload to have failed. Consuming applications would have to be aware of this behavior and provide clean messages/warnings/errors around enabled profilers without uploads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants