Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a test name contains . then the Test explorer is going to create a new branch/node #2013

Open
MangelMaxime opened this issue Jun 2, 2024 · 0 comments

Comments

@MangelMaxime
Copy link
Contributor

MangelMaxime commented Jun 2, 2024

Describe the bug

[<Test>]
let ``foo.bar`` () =
    Assert.That(1, Is.EqualTo(1))

Gives

CleanShot 2024-06-02 at 23 01 07

We should have foo.bar node and not have it split.

Looking at the TRX we have:

  <TestDefinitions>
    <UnitTest name="foo.bar" storage="/users/mmangel/workspaces/github/fable-compiler/fable.package.sdk/tests/bin/debug/net8.0/fable.package.sdk.tests.dll" id="efe994ad-7390-9305-a138-78e80dce1dac">
      <Execution id="d56ce9e4-e2c8-4fe7-a3ab-e0bfb523d2a5" />
      <TestMethod codeBase="/Users/mmangel/Workspaces/Github/fable-compiler/Fable.Package.SDK/tests/bin/Debug/net8.0/Fable.Package.SDK.Tests.dll" adapterTypeName="executor://nunit3testexecutor/" className="Fable.Package.SDK.Tests" name="foo.bar" />
    </UnitTest>
  </TestDefinitions>

I suppose the test explorer is splitting the name property when it should probably not do that.

Machine infos

  • Operating system: Darwin
  • Arch: arm64
  • VSCode: 1.89.1
  • UI Kind: Desktop
  • Ionide: 7.19.1
  • Runtime: netcore
  • Dotnet version: 8.0.204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant