Make FSAC initialization assume workspacePaths[0] instead of RootPath #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| : SymbolInformation[] = | ||
| let inner (container: string option) (decl: NavigationItem) : SymbolInformation option = | ||
| (symbolFilter: WorkspaceSymbol -> bool) | ||
| : WorkspaceSymbol[] = |
Check notice
Code scanning / Ionide.Analyzers.Cli
Detect if generic type should be in the postfix position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the LSP lib to get deprecation notices for members, then removes the use of RootPath/RootUri in the initialization in favor of just using workspacePaths[0]. This is step one of the overall plan described in #733.
In addition, while removing obsolete usages, I specialized the outputs of
textDocument/documentSymbolandworkspace/symbol.