Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(col): col no longer errors when running in non-browser environment #24603

Merged
merged 4 commits into from
Jan 19, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 19, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #24446

What is the new behavior?

  • Added proper check to see if window is defined
  • There is more work to be done on IonCol to get it working well within SSR, but this patch at least prevents an app from crashing.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 6.0.4-dev.1642625499.0d8dbf9

Note: This will not fully resolve the Next.js issues as I also ran into an issue with Ionicons. Edit: Fixed!

@liamdebeasi liamdebeasi requested a review from a team as a code owner January 19, 2022 19:41
@github-actions github-actions bot added the package: core @ionic/core package label Jan 19, 2022
@liamdebeasi liamdebeasi changed the title fix(col): add window undefined check fix(col): col no longer errors when running in non-browser environment Jan 19, 2022
@sean-perkins sean-perkins self-requested a review January 19, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: In Ionic 6, IonCol doesn't work in SSR
3 participants