chore(status-bar): add SuppressWarnings annotation to StatusBar plugin (Android) #2438
Conversation
|
Released dev build of status-bar with dev version: 8.0.0-dev-2438-20251111T164007.0 |
jcesarmobile
left a comment
jcesarmobile
left a comment
There was a problem hiding this comment.
Instead of annotating the whole methods, can the deprecated calls me moved to new separate private methods and only suppress the new ones with the deprecated code?
Annotating the whole methods can cause that we miss future deprecations.
andredestro
force-pushed
the
chore/statusbar-deprecation-warnings
branch
from
425eef1 to
f6ca182
Compare
andredestro
force-pushed
the
chore/statusbar-deprecation-warnings
branch
from
f6ca182 to
9eeac8b
Compare
jcesarmobile
left a comment
jcesarmobile
left a comment
There was a problem hiding this comment.
I only meant to move the the deprecated code for the new deprecations, the old ones are on methods that no longer work on Android 15+, so there is no need. But since you did it, we can keep it that way.
activity is available in all the plugin, so you can call activity.getWindow() from inside the methods when you need the window instead of passing the window to methods such as getStatusBarColorDeprecated
No description provided.