-
Notifications
You must be signed in to change notification settings - Fork 37
Do not set winerror or filenames if they are None. #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 96.80% 96.52% -0.29%
==========================================
Files 9 9
Lines 564 604 +40
Branches 46 49 +3
==========================================
+ Hits 546 583 +37
- Misses 14 16 +2
- Partials 4 5 +1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I added a test from #82 (comment): def test_real_oserror():
try:
import os
os.open('non-existing-file', os.O_RDONLY)
assert False, 'os.open should have raised an OSError'
except Exception as e:
exc = e
str_output = str(exc)
tblib.pickling_support.install(exc)
exc = pickle.loads(pickle.dumps(exc))
assert isinstance(exc, OSError)
assert exc.errno == 2
assert str_output == str(exc)
Edit: Removed wrong pytest output |
|
Moment. I see different result in debugger. |
|
So it works for me, thanks! |
|
Just released 3.2.0. |
|
Perfect, really thanks 😊 |

@oldium try this.