-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing previous tracers #59
Comments
This sounds like a bug? Do you have an example of how you see the prev tracer still lingering around? Either way the prev tracer area is going to get some rework to make coverage work smoothly so it would be great to get your example tested. |
@robinsonkwame any update? |
Sorry, I just haven't had time to pursue this. I think I discovered that
while previous tracers were listed in memory they weren't firing if they
were shutdown, but I'd have to attempt to recreate the problem again.
…On Wed, May 29, 2019 at 9:50 AM Ionel Cristian Mărieș < ***@***.***> wrote:
@robinsonkwame <https://github.com/robinsonkwame> any update?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#59?email_source=notifications&email_token=AB5ESR4Y32E2TYOAYFNPJRDPX2C3VA5CNFSM4HCZP4DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPMQRQ#issuecomment-496945222>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB5ESRYZZDAYDHITZJ6TZLLPX2C3VANCNFSM4HCZP4DA>
.
|
@robinsonkwame what do you mean by "they were shutdown"? |
@robinsonkwame also note that hunter does not warn you about using it like this: hunter.trace()
hunter.trace() or: with hunter.trace():
with hunter.trace():
... Maybe we could have some sort of warning but how I'd know if the user didn't actually intend to have multiple tracing scopes? |
Excellent library, I just started using
hunter
and have really enjoyed using it.While playing around with hunter and trace I find that I have a lot of
previous
references to tracers that I no longer need.hunter.stop()
will set_last_tracer
to None but if I make another call tohunter.trace(...)
the previous tracers are shown to still reside in memory.What's the best way to clear out unneeded tracers in hunter?
The text was updated successfully, but these errors were encountered: