Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple themes using prefers-color-scheme #173

Open
smebberson opened this issue Jul 4, 2019 · 3 comments
Open

Multiple themes using prefers-color-scheme #173

smebberson opened this issue Jul 4, 2019 · 3 comments

Comments

@smebberson
Copy link

Have you considered offering a light and dark theme and automatically setting them based on the new prefers-color-scheme?

Would you be interested in a PR for this?

@iondrimba
Copy link
Owner

No I haven't considered it. Do you think by looking at the code base, that it would be easy to implement?
Can you send me a simple sketch of how it would look?

@smebberson
Copy link
Author

Your app looks entirely SASS based. Is that correct?

If so, I think it should be fairly simple if we follow something along the lines of https://medium.com/@dmitriy.borodiy/easy-color-theming-with-scss-bc38fd5734d1.

If you're half interested in this idea, I'll try and find some time to put together a quick example.

@iondrimba
Copy link
Owner

You are right about Sass. I'm interest in this idea @smebberson 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants